That was a potential outcome, yes. The Commercial Crew/Cargo programs paid out in milestones; as Boeing has demonstrated, those payments don't depend on a completed product.
That SpaceX was successful is great, and a successful example of why we subsidize risky ventures.
As a more recent example, SpaceX gets paid for the in-development HLS, $2.9B so far for something that does not yet exist. https://www.usaspending.gov/award/CONT_AWD_80MSFC20C0034_800...
They get to keep it if the project fails or is canceled; we may not get anything out of it. But I'm inclined to consider it a good investment.
I don't think milestone payments which you keep even if the project gets cancelled count as a "subsidy".
The same thing happens in the private sector – if a big company hires a contractor to work on a project, and then decides to cancel the project, the contractor usually gets to keep the payment for the work they performed, even though it turned out to be pointless in the long-run – but who would call that a "subsidy"?
> 4.1 Down Payment. The Parties acknowledge that [*…*] of the aggregate [*…*] in payments made by Customer to SpaceX pursuant to the Falcon 1e Agreement shall be applied as a down payment under this Agreement, to be equally between the first Launch Service and the second Launch Service (individually or together, as applicable, the “Down Payment”), as reflected below, against the aggregate Forty-Two Million, Six Hundred Thousand U.S. dollars ($42,600,000) payable under this Agreement. The Parties further acknowledge and agree that, by virtue of execution of this Agreement, any claim, obligation, or liability, or refund that may be owed, under the Falcon 1e Agreement is waived or terminated, as applicable.
They threw money at a risky investment. It paid off, and that's great; it was a very cost-effective use of subsidies.
The Washington Post reporting on this is specifically about government contracts, that is, SpaceX is being paid to provide a service to the government. I don't think I would consider this a subsidy under any reasonable definition.
They have gotten actual subsidies for rural broadband and arguably the incentive tax breaks they've gotten are subsidies; this combines to about $2B or so of true subsidies.