Re:Pickadate.js
by armandososa on Tuesday November 20, 2012 @04:30PM
(#4811442)
https://github.com/amsul/pickadate.js/blob/gh-pages/pickadat... the code is a giant var statement. I don't know why, but somehow that bothers me.
[ Parent
| on HN ]
The lack of semicolons and the use of jshint bothers me.
The fact that the code is very neat and is well documented bothers me.
Also the fact that javascript is a lot more readable when you put a blank line between every two lines bothers me (a lot!).
And that it works perfectly and looks great, man that bothers me.
// If datePassed is true
else if ( datePassed === true ) {
Yes, very well documented. >.>Indeed. In fact, I'd posture that the comments, after the first, are wrong; the lines' intents are to _set_!
// Set the element as readonly
element.readOnly = true
// Get the date today
DATE_TODAY = P.getDateToday()
// Get the date to select
DATE_SELECTED = P.getDateSelected()
// Get the month to focus
MONTH_FOCUSED = P.getMonthFocused()
// Get the date ranges
DATE_MIN = P.getDateRange( SETTINGS.date_min )
DATE_MAX = P.getDateRange( SETTINGS.date_max, 1 )
Re:Pickadate.js
by Stratoscope on Wednesday November 21, 2012 @01:50AM
(#4813161)
// Return the calendarObject
return calendarObject
It's like this all the way through the code!It doesn't lack semicolons, it's only using them where necessary.
looks like a single var pattern inside an immediately invoked function expression to me. works well and great for readability
Re:Pickadate.js
by kevincennis on Tuesday November 20, 2012 @09:32PM
(#4812478)
Thank you for not calling it a "self-executing anonymous function".
I'm a proponent of simply calling them 'immediate functions'.
Yea, I'm not a fan of this pattern, it's a pain to step through with a debugger.