News for hackers. Stuff that matters.
Re:Vouch by adeebshihadeh on Sunday February 08, 2026 @01:41PM (#46937162)
"Open source has always worked on a system of trust and verify"

Not sure about the trust part. Ideally, you can evaluate the change on its own.

In my experience, I immediately know whether I want to close or merge a PR within a few seconds, and the hard part is writing the response to close it such that they don't come back again with the same stuff.

(I review a lot of PRs for openpilot - https://github.com/commaai/openpilot)

Re:Vouch by jgauth on Sunday February 08, 2026 @04:16PM (#46938598)
[delayed]
Re:Vouch by rafram on Sunday February 08, 2026 @01:50PM (#46937261)
> In my experience, I immediately know whether I want to close or merge a PR within a few seconds

Not sure this is what I want to hear about a system that people entrust their lives to on the highway…

Re:Vouch by BowBun on Sunday February 08, 2026 @02:18PM (#46937511)
Why? I don't appreciate comments that cast doubt on decent technical contributors without any substance to back it up. It's a cheap shot from anonymity.
Re:Vouch by 8n4vidtmkvmk on Sunday February 08, 2026 @02:35PM (#46937691)
I'm not the parent but if you know you want to merge a PR "within a few seconds" then you're likely to be merging in bad changes.

If you had left it at know you want to reject a PR within a few seconds, that'd be fine.

Although with safety critical systems I'd probably want each contributor to have some experience in the field too.

Re:Vouch by colinmcdermott on Sunday February 08, 2026 @03:02PM (#46937953)
Sounds like you misunderstood. They didn't say they are merging PRs after a few seconds. Just that the difference between a good one and a bad is often obvious after a few seconds. Edit: typos
Re:Vouch by stavros on Sunday February 08, 2026 @04:17PM (#46938605)
I'm not sure there are many ways to interpret "I know whether I want to merge a PR within a few seconds".
Re:Vouch by jeremyjh on Sunday February 08, 2026 @04:48PM (#46938858)
Yet I also agree with GP.
Re:Vouch by adeebshihadeh on Sunday February 08, 2026 @04:08PM (#46938528)
Exactly, every PR starts with:

1. What’s the goal of this PR and how does it further our project’s goals?

2. Is this vaguely the correct implementation?

Evaluating those two takes a few seconds. Beyond that, yes it takes a while to review and merge even a few line diff.

Re:Vouch by theshrike79 on Sunday February 08, 2026 @05:03PM (#46938999)
"*WANT* to close or *WANT* to merge". Not WILL close or WILL merge.

You look at the PR and you know just by looking at it for a few seconds if it looks off or not.

Looks off -> "Want to close"

Write a polite response and close the issue.

Doesn't look off -> "Want to merge"

If we want to merge it, then of course you look at it more closely. Or label it and move on with the triage.

Re:Vouch by latency-guy2 on Sunday February 08, 2026 @01:57PM (#46937323)
What kind of things would you like to hear? The default is you hear nothing. Most black boxes work this way. And you similarly have no say in the matter.
Re:Vouch by ngcazz on Sunday February 08, 2026 @02:38PM (#46937727)
When there's time, you review, when there isn't you trust...
Re:Vouch by adeebshihadeh on Sunday February 08, 2026 @04:09PM (#46938540)
What's the rush? Building good things takes time.
Re:Vouch by johnnyanmac on Monday February 09, 2026 @03:43AM (#46943079)
deadlines, money, attention. The usual things in industry.
Re:Vouch by 999900000999 on Sunday February 08, 2026 @02:52PM (#46937856)
That's the issue here.

Even if I trust you, I still need to review your work before merging it.

Good people still make mistakes.

Re:Vouch by stavros on Sunday February 08, 2026 @04:16PM (#46938602)
What is the definition of trust if you still have to verify? How does "trust" differ from "untrust" in that scenario?
Re:Vouch by johnnyanmac on Monday February 09, 2026 @03:43AM (#46943074)
trust resudes the verification I suppose. Getting a PR from a trusted contributor would probably have me do a quick scan for obvious mistakes. And they'd know to keep the PR's small and on the right branch to help facilitate a scan.

a new person with a big idea on the slightly wrong (but reasonable) channel would have more work in verification.