News for hackers. Stuff that matters.
Re:Severe performance penalty found in VSCode rendering loop by duskwuff on Monday October 27, 2025 @12:42AM (#45717467)
Even if it is a real performance issue, the reasonable fix would be to move the sort call out of the loop - implementing a new data structure in JS is absolutely not the way to fix this.
Re:Severe performance penalty found in VSCode rendering loop by oe on Monday October 27, 2025 @12:58AM (#45717544)
Adding a new data structure just for this feels like such an AI thing. I've added to our agents.md a rule to prefer using existing libraries and types, otherwise Gemini will just happily generate things like this.
Re:Severe performance penalty found in VSCode rendering loop by nneonneo on Monday October 27, 2025 @12:59AM (#45717547)
There’s clearly functionality to push more work to the current window’s queue, so I would not be surprised if the data structure needs to be continually kept sorted.

(Somewhere in the pile of VSCode dependencies you’d think there’d be a generic heap data structure though)

Re:Severe performance penalty found in VSCode rendering loop by muglug on Monday October 27, 2025 @12:46AM (#45717487)
Right, and also this would show up in the profiler if it were a time sink — and I'm 100% certain this code has been profiled in the 10 years it's been in the codebase.