Re:The Theatre of Pull Requests and Code Review
by singpolyma3 on Thursday September 25, 2025 @04:10PM
(#45378304)
Yes. I think many people have no culture of good commits, so they never use bisect or blame, so they never see the use of good commits. It's a cycle
[ Parent
| on HN ]
Re:The Theatre of Pull Requests and Code Review
by krzyk on Saturday September 27, 2025 @09:01AM
(#45395358)
Good commits are not a requirement form bisect.
I commit when I think something more or less completed, or I want to start a major refactoring and I'm afraid I might need to revert it.
I don't always check if commits are buildable, PR should be, because that is what is merged to master and tip of master should be buildable.
Re:The Theatre of Pull Requests and Code Review
by singpolyma3 on Saturday September 27, 2025 @07:01PM
(#45400074)
If a commit isn't buildable then when you get to it with bisect you have to skip. If this happens once in awhile it's not fatal, but it's sure not helpful