If you can get away with it, why wouldn't you set things up this way? Rules for thee, not for me. You can't try to view power plays like this through the lenses of ethics or morality. The point is to use rules to bind and punish your enemies and to make sure that only your friends can get away with breaking them. You do this with media capture and twisted narratives, taking advantage of the erosion of rule of law as a respected concept among the public.
I think when you're the 'architect' or know the full stack very well, to where you fully repl/grok it and occasionally need to do hot patch type work, the former approach is nice. But, my brain has limited memory and time erodes quickly, so I also know when to rely on the latter approach and I try to do it as much as possible
Ethics and morality.
> You can't try to view power plays like this through the lenses of ethics or morality.
Yes, you can, that's the entire point of ethics and morality.
> The point is to use rules to bind and punish your enemies and to make sure that only your friends can get away with breaking them.
Well, yes, that's the point of the specific actions being discussed; that doesn't make it impossible to look at them through a lens of ethics and morality, it just makes them look bad through such a lens.
Culture transmission is more effective when followers can emulate leaders — so you’ll have an easier time getting people to obey when your goal is to get them to act the way you do. In this case, you’ll expend less political capital on enforcing your policy regarding code reviews and testing if you adhere to the same policy. (And accordingly, have an easier time avoiding disgrace like public failures if your service.)
If you want to view it purely through the lens of power politics, saving your political capital on issues like this preserves it for things with better rewards — eg, you’ll have an easier time getting your projects approved if your manager isn’t constantly having to deal with the fallout of your policy double standards impacting morale. Or for setting a standard that working fewer hours is acceptable if you’re meeting your quotas — which nobody can dispute you’re doing, as the whole teams is validating that you are.
This kind of petty power game is rarely an optimal exercise of power.
I rarely commit the same kind of code the full time professional developer do(when bypassing policies).
Typically it is stuff like urgent patch in prod that may not have coverage , or partial long running refactor which breaks existing tests but better to be able merge quickly than keep the branch constantly free of merge conflicts , or experimental exploratory new type of code(new lang , stack whatever )for which we have to yet evolve processes, part of what the lead is supposed to be exploring and so on.
Although In my experience junior leads more often than not abuse their privileges than use it well.
Trump went on about Hillary’s mail and made it a big thing for political points, not because he was particularly caring or didn’t have infamously bad opsec when he got in.
You lead dev trusted himself more than the team. He was probably right.
Edit: Its safe to say that this story involves multiple levels of hypocrisy by the current administration.
But the problem with them being hypocrites in this regard is that it follows from them doing the same thing Hillary did, and in that case the "fair" way to punish them would be the same way she was punished, which is not at all. So I don't see any real accountability ever coming from this beyond maybe trump firing a couple of sacrificial lambs from his administration.
Because these rules and policies are for people that are judged to need them by the person with the authority and responsibility for making the decision.
Policies like these always have a cost and (hopefully) a benefit. Presumably this lead dev judged that the cost vs benefit didn't make sense for themselves but did for others. It's entirely possible they were correct.
https://www.browserstack.com/guide/code-review-benefits
> Code Review enhances the maintainability of the Code. It ensures that multiple people are aware about the code logic and functioning, which makes it easy to maintain in case the original author of the code is unavailable.
The fact that you've been "hacking" for three decades and never considered this isn't something to wear as a badge of honor. As for your absurd straw man about everyone on the team reviewing every line of code, I've never seen one organization that does that.
awareness does not imply understanding :)
If, however, a junior develop is responsible for making a change, but has no authority to make the change, then there is a problem.
Same goes for some “10x developers” who are fast because the rules don’t apply to them. Meanwhile the rules slow everyone else down (yea big surprise he is faster). And everyone else has to clean up after these guys when they get sloppy.
Because the goal is to keep risk to a reasonable level, not necessarily minimize it as much as possible.
But for me the foundational issue is that my coworkers aren't holding up the bar when reviewing contractor code. And reviewing all the code isn't my job description.
Meanwhile my job description does include maintaining a system my coworkers don't really know anything about, and so I mostly make sure it's tests pass and let me manager know about anything I need to do to it.
I don't see a problem with it (as long as he can't transfer the blame somewhere else).
But him? Half that time he'd approve his own changes without review, the other half he would force-push and bypass the CI system entirely.
He knew the system well and seemed to do enough local testing to avoid major breakage but still. Why have a bunch of rules and policies that you do not follow yourself?