News for hackers. Stuff that matters.
Re:Good code is rarely read by petermcneeley on Saturday June 15, 2024 @04:35PM (#40692525)
I think you are not reasoning correctly here

Adding features to a code means it was incomplete. Misunderstanding input/output usually means it is poorly documented or lacked a good API. A good API works at the surface (in/out) and not in the volume.

Really good code solves a problem completely. I have worked with such code and yes almost nobody ever goes into this code (and makes changes).

Re:Good code is rarely read by wavemode on Saturday June 15, 2024 @04:49PM (#40692604)
> Adding features to a code means it was incomplete

In practice this isn't true. The code may have been perfect and complete according to the business requirements of 1 month ago. But the business requirements of 1 month ago and today are often completely different.

Re:Good code is rarely read by petermcneeley on Saturday June 15, 2024 @05:52PM (#40692960)
This falls outside of my experience. I am systems or "backend".
Re:Good code is rarely read by xboxnolifes on Saturday June 15, 2024 @08:08PM (#40693631)
I'm not familiar with many systems or backend software that are still actively used, multiple decades old, and not still receiving updates. If it's not even a decade old, it's not old enough to say requirements won't change.
Re:Good code is rarely read by phito on Sunday June 16, 2024 @04:52AM (#40695652)
How does being a backend engineer makes you safe from business requirements changes? It doesn't add up to me.
Re:Good code is rarely read by cjblomqvist on Saturday June 15, 2024 @05:26PM (#40692828)
I thought you extended, not edit, really good code to achieve that
Re:Good code is rarely read by x0x0 on Saturday June 15, 2024 @04:49PM (#40692602)
> Adding features to a code means it was incomplete.

That definitely implies code can't be good if needs change, which makes no sense to me.

Re:Good code is rarely read by tanseydavid on Saturday June 15, 2024 @07:14PM (#40693398)
Missing feature implies an error at the Requirements level.

This does not impact readability or the idea of "good code" in my opinion.

You could have an application that is missing features which still contains examples of "good code". Learning about "good code" by reading the source code of this application won't really give any direct hints of missing features...the granularity is different.

Re:Good code is rarely read by philosopher1234 on Saturday June 15, 2024 @10:04PM (#40694162)
Why does it imply an error? The world changes, is that an error? You built around one reality, and reality changed. No one can predict the future.
Re:Good code is rarely read by mewpmewp2 on Sunday June 16, 2024 @01:05PM (#40698516)
What about changing features? E.g. a feature has to change 2 years down the line because certain laws are passed and this changes how the business logic should behave.
Re:Good code is rarely read by jacoblambda on Saturday June 15, 2024 @04:54PM (#40692620)
Adding features means it was incomplete. Good code can essentially always be built upon instead of modified.
Re:Good code is rarely read by oblio on Saturday June 15, 2024 @05:10PM (#40692723)
Laws change, business requirements change, network protocols/external APIs change, ...

Your approach is I guess valid for self contained algorithmic code, i.e. 0.000001% of code out there.

Re:Good code is rarely read by x0x0 on Saturday June 15, 2024 @05:06PM (#40692696)
But code can be complete and then become so-called incomplete because, again, needs change.

eg someone releases a new file format. You believe ffmpeg is bad code?

Re:Good code is rarely read by mewpmewp2 on Sunday June 16, 2024 @01:07PM (#40698529)
In that case you could argue that you would be just writing new code to write a handle for that file format.

In ffmpeg case I assume this is how it would be.

Re:Good code is rarely read by exe34 on Saturday June 15, 2024 @04:59PM (#40692648)
is "building upon" different from "adding features", in this new terminology?
Re:Good code is rarely read by aaronbrethorst on Saturday June 15, 2024 @04:56PM (#40692628)
Let me guess, you work on game engines?
Re:Good code is rarely read by petermcneeley on Saturday June 15, 2024 @05:34PM (#40692890)
I have but I dont currently. I am guessing the implication is that game engines have good code while other subsectors do not.
[dead]
Re:Good code is rarely read by petermcneeley on Saturday June 15, 2024 @05:36PM (#40692895)
Re:Good code is rarely read by nsinreal on Sunday June 16, 2024 @05:26AM (#40695788)
Well, what's wrong with code being incomplete at some point of time?

Is it not waterfall enough? Is it too much learning from customers? Is it too small PRs of duration less than 1-6 months? Is it not enough premature optimization?