You gave a numbered list of good suggestions and wrote the kernel of a detailed, thoughtful comment, but sabotaged it with poor framing and assumptions. I don't care or anything, but for your benefit: this is a nerdly inclination that will serve you very, very poorly in your professional career. HN often has the opposite problem from your comment (a bias towards being "right" even when we're not "correct", such as in civil liberties stories); here, you're "correct" but not "right", since adoption of all your recommendations is unlikely to change the bottom line for Patrick at all.
One consultant to (I presume) another: my suggestion for next time: either:
(a) (expensively) do exhaustive research so you can frame your high-level assessment and recommendations in the context of someone's business (ie, expend the effort to make sure you're both correct and right), or
(b) (much simpler) develop a habit of writing your comments in a neutral, helpful tone, so that you can be correct without having to be right at all.
By the way, I feel comfortable writing this comment because I have oh my God exactly the same problem with my comments. Look at me on a crypto thread sometime.
I hope.
Is this a matter of the problems pointed out are "correct" technically, but they may or may not be the "right" thing to spend time on?
"Is this a matter of the problems pointed out are "correct" technically, but they may or may not be the "right" thing to spend time on?"
I'm pretty sure you've already got it, this sounds like it. I would only add that a conscientious person checks whether their comment is adding to the conversation (not anxiously; just subconsciously, as a habit). The parent to your comment is saying that if you're 'correct' you're in the clear that way.
I think the thing about being "right" is that if you're right (i.e. your addressee is wrong) you have enough social capital to take that tone with somebody. If you're wrong and you take up an 'I'm right' tone, you come off like you don't care about thinking things through before you make an investment of your time.
He's not "right", though, because adopting any of these recommendations would cost anywhere from tens- to thousands- of dollars, and would be unlikely in the aggregate, even if all of them were adopted, to make Patrick one additional dollar.
Other parts are the way they are simply because, well, we have very different standards for things which should delay shipping. Bits are cheap, my time is expensive, optimizing for bits saved (on my cute little re-demoted-to-hobby project, no less) seems like a poor idea.
Similarly, failure to achieve pixel perfection of the price display in Australian dollars is not exactly the kind of thing that would scare me away from a design. You know what would terrify me? "It looks nice -- women generally hate it." That would cause the business to fold like an origami crane. Happily, it doesn't seem to have that problem.
I'm generally happy to get feedback, even negative feedback, but as one professional to another your feedback doesn't leave me with the impression "Tie a string around my finger to address this later" because it does not persuasively implicate anything I really care about.
It's a very good excuse to force people on improving their HTML and website speed, but I still would like to see the impact of the Google organic results after only speed improvement and bad HTML fixes.
http://www.xe.com/ucc/convert/?Amount=29.95&From=USD&...
It might be worth revisiting those non-USD prices...
Removing them after the fact with a HTML tidier would work, or you could just not care and let gzip handle the compression.
Jinja2 is a generic templating engine, and as such can't make assumptions about relevance of whitespace.
However, writing an extension on top of it isn't hard, and mitsuhiko has written an extension to do that.
The extra whitespaces are most probably the template output. If he is using erb, erb is a generic template and doesn't make assumptions about relevance of whitespace. If you are optimizing by hand, you will still have all the newlines and indents in the output.
Some people use minifiers, most people don't care. Almost all servers and clients speak gzip, and the extra overhead is so low on the list of things to optimize that it probably isn't even on the list.
> 3- JavaScript, I see that you are loading a good chunk of JavaScript in the HEAD and you are loading a bunch of it in the end. For example the Amazon JS file (http://s3.amazonaws.com/new.cetrk.com/pages/scripts/0004/737...) is certainly not usable, and is yet a whole HTTP request.
Again, I am taking a guess. layout.html.erb yields under body, and head and scripts are same for all pages. Now patio11 can hand include just the needed scripts on every page, but he chose to include all scripts on all pages. This isn't something the designer controls.
> 2- http://dl.dropbox.com/u/2777218/shot2.png
That menu change really looks weird.
I doubt he has the time and 'itch' right now, though.
So take this as a constructive criticism and I have nothing against the designer, nor I know him.
I'll begin with the HTML/CSS parts. He is a Web Designer, and not simply a designer; so he should use the best practices
1- Use the HTML5 Doctype
2- Removes unnecessary space (empty lines and spaces). Why the extra bits?
3- JavaScript, I see that you are loading a good chunk of JavaScript in the HEAD and you are loading a bunch of it in the end. For example the Amazon JS file (http://s3.amazonaws.com/new.cetrk.com/pages/scripts/0004/737...) is certainly not usable, and is yet a whole HTTP request.
4- In the JavaScript file (http://images2.bingocardcreator.com/javascripts/bcc-all.js?1...), you are loading a ColourPicker and other unused stuff. This is a waste of bandwidth, latency, memory and speed. You don't need JavaScript in your main page, apart from the analytic and maybe A/B testing stuff.
5- Unobtrusive JavaScript. (line 181 of the HTML)
Enough, though there are endless problems with the coding part so don't take this list as an exhaustive review. For the design, it just sucks. I agree that simple designs (K.I.S.S) are better, but they should be crafted. I won't complain much, but here are two snapshots of what I'm talking about
1- http://dl.dropbox.com/u/2777218/shot1.png
2- http://dl.dropbox.com/u/2777218/shot2.png
Again, take this as a constructive feedback and I have nothing against your business; and what matters finally are the sales/$$$.
Take a look at http://www.premiumpixels.com/ if you want to see some carefully crafted designs.