If you need to opt-in to create an account then it is illegal. Yes the discount code for newsletter signup is a result of GDPR consent requirement along with growth hacking technique popularity that is incredibly annoying.