News for hackers. Stuff that matters.

A comment on I got robbed of my first kernel contribution. Parent comment

Re:I got robbed of my first kernel contribution by shakow on Wednesday September 27, 2023 @05:32AM (#37672304)
> I'd be pissed if I put in a lot of effort revising my contributions to a project, only to be told at the end that "I like my version better, so go away!"

Frankly, I think that's a non-trivial problem to solve: how to get the assumedly better fix while not ruffling the feathers of the more junior contributor so not to discourage on-ramping.

I guess the best way to do it would be to have a co-authored-by tag, or something akin.

[ Parent | on HN ]
Re:I got robbed of my first kernel contribution by ghosty141 on Wednesday September 27, 2023 @05:35AM (#37672329)
I see multiple people saying the authors fix was in a way inferior. Where is this mentioned?
[ Parent | on HN ]
Re:I got robbed of my first kernel contribution by toyg on Wednesday September 27, 2023 @05:49AM (#37672448)
It was stated by the maintainer as the reason for discarding the author's contribution.
[ Parent | on HN ]
Re:I got robbed of my first kernel contribution by Sprocklem on Wednesday September 27, 2023 @02:37PM (#37679176)
What the maintainer actually said was [0]:

> Thanks for your patch, but I wanted to fix it differently. Can you try the patch below and make sure it fixes the bug for you?

Which to me, at least, reads very differently than claiming the author's patch is worse.

[0] https://lists.ozlabs.org/pipermail/linuxppc-dev/2022-June/24...

(Credit to nolist_policy for pointing this out upthread.)

[ Parent | on HN ]
Re:I got robbed of my first kernel contribution by shakow on Wednesday September 27, 2023 @07:55AM (#37673357)
We can't really know as we can't see the author's patch, but given that (i) the guy answering is responsible for the whole CPU architecture in Linux and (ii) the author mourns his putative contributor badge but does not criticize the other patch, that's a bet I'm ready to take.
[ Parent | on HN ]
Re:I got robbed of my first kernel contribution by hnfong on Wednesday September 27, 2023 @12:16PM (#37676920)
FYI

https://lists.ozlabs.org/pipermail/linuxppc-dev/2022-June/24...

https://lore.kernel.org/all/20220609133245.573565-1-mpe@elle...

[ Parent | on HN ]
Re:I got robbed of my first kernel contribution by cortesoft on Wednesday September 27, 2023 @11:54AM (#37676566)
Obviously the author is not going to say their fix was worse, but commenters on here have described why: https://news.ycombinator.com/item?id=37675544
[ Parent | on HN ]
Re:I got robbed of my first kernel contribution by ariel-miculas on Thursday September 28, 2023 @02:00PM (#37693248)
see https://news.ycombinator.com/item?id=37692883
[ Parent | on HN ]
Re:I got robbed of my first kernel contribution by hmottestad on Wednesday September 27, 2023 @05:43AM (#37672405)
A pull request and some comments to help the author understand what needs to be adjusted is a common way to handle this with the projects that I work with.
[ Parent | on HN ]