Using mmap to make LLaMA load faster

Re:Using mmap to make LLaMA load faster by chad1n on Wednesday April 05, 2023 @01:21PM (#35457497)

People were pretty mad because he changed the magic to match his name, instead of bumping the magic version, like he was supposed to. https://github.com/ggerganov/llama.cpp/blob/master/llama.h#L... . He didn't come with the idea in the first place, it was brought up by another github user. On top of all of these, users also needed to migrate their weights once again.

[ Parent | on HN ]

Re:Using mmap to make LLaMA load faster by 514723553 on Wednesday April 05, 2023 @01:30PM (#35457629)

If people were mad at Greg for changing or not changing a magic number--then they can just make a PR to fix it! That'd be so easy!

[ Parent | on HN ]

Re:Using mmap to make LLaMA load faster by chad1n on Wednesday April 05, 2023 @01:38PM (#35457727)

Greg didn't change it, it was changed in Jart's pull request. Also they can't just make a PR to fix it, because the models were already converted to that magic string that was changed for no reason.

[ Parent | on HN ]

Re:Using mmap to make LLaMA load faster by 514723553 on Wednesday April 05, 2023 @01:53PM (#35457991)

Well if it wasn't Greg, then I feel like I need to ask--why the heck would you use he/him to refer to Justine? I'm glad you've changed your mind and referred to her with they/them above, though!

> they can't just make a PR to fix it, because the models were already converted to that magic string that was changed for no reason.

I _think_ the magic string was changed _because_ of versioning issues--it sounds like you're arguing that the magic version number _instead_ of the magic string should've been changed...but it sounds like Justine _was_ concerned with versioning, even if the versioning wasn't done in what you're saying is the best possible way. I just don't think that "one magic number was changed instead of another magic number" really warrants this level of animosity.

[ Parent | on HN ]

Re:Using mmap to make LLaMA load faster by vore on Wednesday April 05, 2023 @01:30PM (#35457618)

jart is a woman, for what it's worth.

[ Parent | on HN ]

Re:Using mmap to make LLaMA load faster by chad1n on Wednesday April 05, 2023 @01:58PM (#35458051)

I just presented the drama and I referred to him as `he` as a developer, my teammates are mostly male, so I usually say `he`.

[ Parent | on HN ]

Re:Using mmap to make LLaMA load faster by tedunangst on Wednesday April 05, 2023 @02:06PM (#35458178)

Do you also refer to your female teammates as he?

[ Parent | on HN ]

Re:Using mmap to make LLaMA load faster by whimsicalism on Wednesday April 05, 2023 @02:01PM (#35458097)

Right, so maybe you shouldn't do that?

[ Parent | on HN ]

[dead]

Re:Using mmap to make LLaMA load faster by vore on Wednesday April 05, 2023 @02:29PM (#35458499)

Did you make a new account just to do this?

[ Parent | on HN ]

Re:Using mmap to make LLaMA load faster by dekhn on Wednesday April 05, 2023 @02:12PM (#35458269)

This sort of statement really don't contribute anythign to the discussion and in fact greatly distracts from the technical content. We don't need to hear your opinions about trans people in this thread.

[ Parent | on HN ]

Re:Using mmap to make LLaMA load faster by BeefWellington on Wednesday April 05, 2023 @01:58PM (#35458058)

Greg's own comment on the changes:

> Regarding the version comment - yes, the plan was to bump versions and no the magic. But I'm ok to change the magic to commemorate the significance of this update. In fact, maybe we can make this a thing and everybody who makes a significant contribution to the project will get their initials appended to the version. What do you think? smile

[ Parent | on HN ]