Re:Using mmap to make LLaMA load faster
by 514723553 on Wednesday April 05, 2023 @01:30PM
(#35457629)
If people were mad at Greg for changing or not changing a magic number--then they can just make a PR to fix it! That'd be so easy!
[ Parent
| on HN ]
Greg didn't change it, it was changed in Jart's pull request. Also they can't just make a PR to fix it, because the models were already converted to that magic string that was changed for no reason.
Re:Using mmap to make LLaMA load faster
by 514723553 on Wednesday April 05, 2023 @01:53PM
(#35457991)
Well if it wasn't Greg, then I feel like I need to ask--why the heck would you use he/him to refer to Justine? I'm glad you've changed your mind and referred to her with they/them above, though!
> they can't just make a PR to fix it, because the models were already converted to that magic string that was changed for no reason.
I _think_ the magic string was changed _because_ of versioning issues--it sounds like you're arguing that the magic version number _instead_ of the magic string should've been changed...but it sounds like Justine _was_ concerned with versioning, even if the versioning wasn't done in what you're saying is the best possible way. I just don't think that "one magic number was changed instead of another magic number" really warrants this level of animosity.