News for hackers. Stuff that matters.
Re:ChatGPT powered GitHub code review app by dvngnt_ on Tuesday March 07, 2023 @03:46PM (#35060967)
wouldn't it be better to do this locally before the PR, if the bot's suggestions are valid then the user would have to make another commit.

maybe this would work if a reviewer wanted to highlight code for a question/comment and then the bot could add their two cents

Re:ChatGPT powered GitHub code review app by eikenberry on Tuesday March 07, 2023 @04:05PM (#35061195)
It has to be an online service until they get the models more refined and hardware advanced enough that you can run these locally. If you can't run the model locally then it might as well be a service you tie into at the service (eg. github) level. That is, IMO, services are most useful with other services.
Re:ChatGPT powered GitHub code review app by andiareso on Tuesday March 07, 2023 @04:06PM (#35061214)
I think they are saying the app could be a pre-commit hook where their API is hit before code goes up to remote
Re:ChatGPT powered GitHub code review app by eikenberry on Tuesday March 07, 2023 @04:27PM (#35061505)
Yes. I'm saying that due to this relying on an external service it would be inappropriate for a pre-commit hook as you could only commit while online.
Re:ChatGPT powered GitHub code review app by habitue on Tuesday March 07, 2023 @04:31PM (#35061535)
pre-push hook?
Re:ChatGPT powered GitHub code review app by verdverm on Tuesday March 07, 2023 @04:46PM (#35061706)
git commit --no-verify ?
Re:ChatGPT powered GitHub code review app by bottled_poe on Tuesday March 07, 2023 @05:16PM (#35062031)
If the developer wants to slow their own development workflow by delaying the code review, that’s.. concerning.
Re:ChatGPT powered GitHub code review app by verdverm on Tuesday March 07, 2023 @07:58PM (#35063760)
in what way is your comment pertaining to this thread?

If a user is offline, they are not going to be able to push code for review anyway. Either way, it seems prudent to shift validation and checks closer to the developer, before pushing code. Otherwise you end up with a series of commit & push, wait for check, commit & push fixes, wait for check, commit & push more fixes...

Re:ChatGPT powered GitHub code review app by lwhi on Tuesday March 07, 2023 @05:17PM (#35062046)
> [...] it would be inappropriate for a pre-commit hook as you could only commit while online.

Why does that matter?

Re:ChatGPT powered GitHub code review app by eurasiantiger on Tuesday March 07, 2023 @05:37PM (#35062291)
Hey, some of us live in caves.
Re:ChatGPT powered GitHub code review app by eloff on Tuesday March 07, 2023 @06:00PM (#35062549)
Add the —no-verify flag when working out of your cave.
Re:ChatGPT powered GitHub code review app by dvngnt_ on Tuesday March 07, 2023 @04:23PM (#35061457)
to clarify, i mean the processing would still be done remotely, but it could be done earlier in the cycle
Re:ChatGPT powered GitHub code review app by jhatemyjob on Tuesday March 07, 2023 @04:18PM (#35061379)
No, because that would be way too close to the user, it would be almost impossible to market it as a service you have to pay for ;)
Re:ChatGPT powered GitHub code review app by dev_tty01 on Tuesday March 07, 2023 @04:24PM (#35061472)
Hmm. Not seeing your argument. The company has an API key. Employees query the local service which passes it up to the pay service. What does user executed vs. github commit triggered have to do with anything? What am I missing?
Re:ChatGPT powered GitHub code review app by sneak on Tuesday March 07, 2023 @04:05PM (#35061191)
This solution doesn't require the installation of software, or any changes to the existing workflow.
Re:ChatGPT powered GitHub code review app by winkmaster on Wednesday March 08, 2023 @06:53AM (#35067917)
The bot does not work like a linter or testing framework, these are suggestions that are subject to discussions, and the pull request is a great place to get reviews from the team