Re:ChatGPT powered GitHub code review app
by eikenberry on Tuesday March 07, 2023 @04:27PM
(#35061505)
Yes. I'm saying that due to this relying on an external service it would be inappropriate for a pre-commit hook as you could only commit while online.
[ Parent
| on HN ]
pre-push hook?
Re:ChatGPT powered GitHub code review app
by verdverm on Tuesday March 07, 2023 @04:46PM
(#35061706)
git commit --no-verify ?
Re:ChatGPT powered GitHub code review app
by bottled_poe on Tuesday March 07, 2023 @05:16PM
(#35062031)
If the developer wants to slow their own development workflow by delaying the code review, that’s.. concerning.
Re:ChatGPT powered GitHub code review app
by verdverm on Tuesday March 07, 2023 @07:58PM
(#35063760)
in what way is your comment pertaining to this thread?
If a user is offline, they are not going to be able to push code for review anyway. Either way, it seems prudent to shift validation and checks closer to the developer, before pushing code. Otherwise you end up with a series of commit & push, wait for check, commit & push fixes, wait for check, commit & push more fixes...
> [...] it would be inappropriate for a pre-commit hook as you could only commit while online.
Why does that matter?
Re:ChatGPT powered GitHub code review app
by eurasiantiger on Tuesday March 07, 2023 @05:37PM
(#35062291)
Hey, some of us live in caves.