Re:Null is an Object in JavaScript
by abdnafees on Tuesday February 07, 2023 @08:57AM
(#34692766)
Why even? Why don't they fix it?
[ Parent
| on HN ]
Supposedly "because it would break existing code".
> This is a bug and one that unfortunately can’t be fixed, because it would break existing code.
Re:Null is an Object in JavaScript
by 29athrowaway on Wednesday February 08, 2023 @01:36AM
(#34704887)
Linus Torvalds has long had an ironclad rule, "don't break userspace" which sounds like the same thing
from the hyrum's law link:
With a sufficient number of users of an API,
it does not matter what you promise in the contract:
all observable behaviors of your system
will be depended on by somebody.
Re:Null is an Object in JavaScript
by readthenotes1 on Wednesday February 08, 2023 @01:37AM
(#34704892)
"The difference between a bug and a feature is longevity."
-said by someone last millennium
Re:Null is an Object in JavaScript
by bryanrasmussen on Wednesday February 08, 2023 @03:49AM
(#34705735)
that's wrong, but it's been around so long I guess we have to accept it.
After asking the question, I looked for an answer and found the is-object npm package. It utilizes a null check to make sure a variable is an object. This utility has 6.6 million weekly downloads.
The logic in the isObject function will break because the second condition would then be invalidated. Resulting in a bad day for 6.6 million projects. It took me a while to digest the magnitude. Maybe because I just started as an SWE.
Re:Null is an Object in JavaScript
by andrewmackrodt on Wednesday February 08, 2023 @04:46AM
(#34706113)
If a language change were to update `typeof null` to return `"null"` isObject would not break, the second condition would only be unnecessary.
However, other code which may make assertions on null values after checking the value is an object would break.
Re:Null is an Object in JavaScript
by white_dragon88 on Wednesday February 08, 2023 @06:53AM
(#34706905)
Well it’s supposed to pose a philosophical argument. A related phrase might be ‘perfect is the enemy of good’, etc
Re:Null is an Object in JavaScript
by chrismorgan on Wednesday February 08, 2023 @06:43AM
(#34706842)
You drastically underestimate how much code depends on typeof null being "object". It’s extremely common in generic/library code. If you changed it to produce, say, "null", vast numbers of websites would completely break. As a simple example, a brief glance at the React and ReactDOM source code, inspecting the first few /typeof.*'object'/ matches, shows that in React, component.setState(null), and in ReactDOM, rendering class-based components with null state (which I’m guessing will be pretty much normal in existing code bases, even if it’s an older pattern now; but I haven’t ever used React seriously), would both throw an exception.
Existing code might rely on this behavior, so if it changed some sites will stop working. Even if those sites were updated to the new behavior, browsers are not updated at the same time, so either way there would be a lot of breakage.
And some sites will never be updated because they are not actively maintained.