No, in general, I agree with code review comments my senior developers make. I'm talking about the difference between "best practices" and actual best practices or in the difference between "this works, but next time, a better architecture would be x, let's refactor next time we come back to this" and "I'm blowing up the sprint"
When I hear comments like this from managers it’s generally a sign that I need to start planning an exit strategy.
edit: Also, “my senior developers?” They’re human beings, not your property, dude
As a manager, the Junior shouldn’t be on the critical path solo. That’s just bad management.
In my experience there is rarely ever a “next time” and “fix it later” becomes “fix it never”. It’s always cheapest to fix worst practices up front rather than letting them metastasize into a huge pile of technical debt later. It’s also rare to find anybody interested in or willing to go back and fix old stuff when priorities often involve chasing the next shiny thing.
Then the code that gets touched the most gets touched up the most. Code that doesn't ever get touched is fine being kinda crappy.
hmm...this would sound so much better if you felt your team was pushing for "actual" best practices.
Perhaps it's all working well, but from your words there's so much underlying tension and your clarification adds further distanciation between you and your team.
I'd hate to be on either side of this to be honest.
You see a clear dichotomy between well written code and what your senior engieers see as enforceable best practices.
I'd guess you also see half of the time your team spends on coding as some useless nitpicking you're letting them get away with by sheer generousity or bcause you don't have a choice...From the looks of it that can't be a healthy team dynamic