News for hackers. Stuff that matters.
Re:Don’t Teach During Code Reviews by logbiscuitswave on Sunday February 05, 2023 @06:35PM (#34671055)
“this works, but next time, a better architecture would be x, let's refactor next time we come back to this”

In my experience there is rarely ever a “next time” and “fix it later” becomes “fix it never”. It’s always cheapest to fix worst practices up front rather than letting them metastasize into a huge pile of technical debt later. It’s also rare to find anybody interested in or willing to go back and fix old stuff when priorities often involve chasing the next shiny thing.

Re:Don’t Teach During Code Reviews by strix_varius on Sunday February 05, 2023 @06:49PM (#34671194)
Exactly - this, coupled with phrases like "blowing up the sprint," suggests that nobody on this team is likely to trust that the offer of "fixing it later, next time" will be held to.
Re:Don’t Teach During Code Reviews by bcrosby95 on Sunday February 05, 2023 @09:10PM (#34672379)
My rule is code at inception doesn't have to be the best, but every time you touch existing code you must make it better.

Then the code that gets touched the most gets touched up the most. Code that doesn't ever get touched is fine being kinda crappy.