News for hackers. Stuff that matters.
Re:Don’t Teach During Code Reviews by lelandfe on Sunday February 05, 2023 @05:25PM (#34670323)
Code review is the most common arena for getting feedback on my code. My team doesn't pair very often, though I think that's more effective. I don't believe I have other opportunities for it...?
Re:Don’t Teach During Code Reviews by astrange on Sunday February 05, 2023 @06:25PM (#34670961)
If you're getting complete rearchitecture feedback in a code review, something's wrong because that's too late for it. Especially if it means rewriting later changes they haven't put up yet.
Re:Don’t Teach During Code Reviews by dilyevsky on Monday February 06, 2023 @02:25PM (#34682753)
The wrong part happened when sender went to work on something alone for a long time then sent a giant PR all at ones instead of progressive set of changes. Don’t blame the reviewer for having to either compromise their integrity by letting it slide into the codebase or getting onto the likes of TP’s shitlist by putting their foot down.