News for hackers. Stuff that matters.
Re:Stop requiring only one assertion per unit test: Multiple... by sitkack on Saturday November 05, 2022 @12:24PM (#33482946)
You should write an episode of Seinfeld.

I was a TL on a project and I had two "eng" on the project that would make test with a single method and then 120 lines of Tasmanian Devil test cases. One of those people liked to write 600 line cron jobs to do critical business functions.

This scarred me.

Re:Stop requiring only one assertion per unit test: Multiple... by ckastner on Saturday November 05, 2022 @01:14PM (#33483394)
> One of those people liked to write 600 line cron jobs to do critical business functions.

I was a long-time maintainer of Debian's cron, a fork of Vixie cron (all cron implementations I'm aware of are forks of Vixie cron, or its successor, ISC cron).

There are a ton of reasons why I wouldn't do this, the primary one being is that cron really just executes jobs, period. It doesn't serialize them, it doesn't check for load, logging is really rudimentary, etc.

A few years ago somebody noticed that the cron daemon could be DoS'ed by a user submitting a huge crontab. I implemented a 1000-line limit to crontabs thinking "nobody would ever have 1000-line crontabs". I was wrong, quickly received bug reports.

I then increased it to 10K lines, but as far as I recall, users were hitting even that limit. Crazy.

Re:Stop requiring only one assertion per unit test: Multiple... by kragen on Saturday November 05, 2022 @06:07PM (#33486407)
Is Dillon cron a fork of Vixie cron?
Re:Stop requiring only one assertion per unit test: Multiple... by ckastner on Saturday November 05, 2022 @07:25PM (#33487022)
Hadn't heard of it before, and it appears not to be.

There indeed exist a few non-Vixie-cron-derivative implementations but as far as I'm aware, all major Linux and BSD distributions use a Vixie cron derivative.

Edit: I see now where I caused confusion. In my original post, I should have said all default cron implementations.

Re:Stop requiring only one assertion per unit test: Multiple... by kragen on Saturday November 05, 2022 @08:14PM (#33487345)
I thought Dillon cron was the default cron in Slackware? Hard to be a more major Linux distribution than Slackware, in terms of historical impact if not current popularity.
Re:Stop requiring only one assertion per unit test: Multiple... by ckastner on Sunday November 06, 2022 @02:37AM (#33490141)
Could be. Slackware is a popular name, but I would call it "niche" rather than a major distribution. Just my personal view, obviously.
Re:Stop requiring only one assertion per unit test: Multiple... by kragen on Sunday November 06, 2022 @05:57PM (#33498454)
I just confirmed with a Slackware user today, it still does use Dillon cron. I had a vague memory from before I switched from Slackware to Debian late last millennium.
Re:Stop requiring only one assertion per unit test: Multiple... by ttkciar on Sunday November 06, 2022 @08:18PM (#33499819)
It always gives me a spell of cognitive dissonance when someone points out that Slackware is no longer a "major" distribution.

It used to be the major distribution. Funny how times change.