News for hackers. Stuff that matters.
Re:Curl doesn't add libproxy due to its quality issues by ushakov on Sunday October 23, 2022 @08:45AM (#33306521)
He’s concerned about adding 1 dependency, while you add thousands to your node_modules without the slightest doubt

What a class act

Re:Curl doesn't add libproxy due to its quality issues by eCa on Sunday October 23, 2022 @08:52AM (#33306572)
To be fair, most other projects aren’t as far up-river as curl. Any project they depend on becomes at least as important as curl itself.
Re:Curl doesn't add libproxy due to its quality issues by blowski on Sunday October 23, 2022 @09:27AM (#33306820)
Exactly, everything’s a trade-off. And the trade-offs will be different for a very widely used system package like curl compared to, say, a small in-house ERP system or low-traffic website.
Re:Curl doesn't add libproxy due to its quality issues by manfre on Sunday October 23, 2022 @09:05AM (#33306672)
I appreciate when app maintainers set a standard for their dependencies. I wish it wasn't so rare.

Node needs a static dependency checker to prevent using anything that has isodd or similar useless modules in its dependency graph.

Re:Curl doesn't add libproxy due to its quality issues by manuelabeledo on Sunday October 23, 2022 @08:48AM (#33306548)
To be fair, is there any other way around while working with node?

Everything in the ecosystem is a dependency.

Re:Curl doesn't add libproxy due to its quality issues by nickjj on Sunday October 23, 2022 @09:41AM (#33306924)
It depends on what you're doing.

I wrote https://www.npmjs.com/package/esbuild-copy-static-files only using the Node standard library.

It was funny writing the readme file though where "No 3rd party dependencies" ended up being called out as a feature.

Re:Curl doesn't add libproxy due to its quality issues by johnny22 on Sunday October 23, 2022 @05:44PM (#33310581)
i see "no third party dependencies" often as a feature with C++ libs, and I doubt that's the only place.
Re:Curl doesn't add libproxy due to its quality issues by lightswitch05 on Sunday October 23, 2022 @08:57AM (#33306605)
I’ve written a library with zero production dependencies. Of course I have Jest as a development dependency which pulls in all sorts of stuff. It would be difficult to make a zero-dependency library. As for not having production libraries, this was my experience:

1. Using the https module directly was more work than I expected, especially with error handling. This made me really look forward to the new Fetch API coming out.

2. No CLI parser. Its not like parsing args is a LOT of work - but its also something that is already solved and having to write support for that directly was a bummer

3. No logging library. This one was pretty easy. Create a little class with logging levels. Again this is something that is very common that would have been nice to use a package for.

Re:Curl doesn't add libproxy due to its quality issues by laundermaf on Sunday October 23, 2022 @09:07AM (#33306690)
What you describe is exactly why people use dependencies. You just decided to trade your time for the noble act of having “no production dependencies”, while one of the 275 modules installed by Jest (real number) stole your production secrets anyway.

As for point 2, Node 18.1 I think just introduced a native argument parser.

Re:Curl doesn't add libproxy due to its quality issues by 2fast4you on Sunday October 23, 2022 @09:25AM (#33306809)
Why would the test dependencies have access to production secrets? They only get installed while developing
Re:Curl doesn't add libproxy due to its quality issues by hombre_fatal on Sunday October 23, 2022 @10:12AM (#33307165)
They still get run on a developer’s machine most of the time and are at least installed there where they can run arbitrary code on install. And there are juicy secrets beyond just production server secrets sitting on your laptop.
Re:Curl doesn't add libproxy due to its quality issues by adobrawy on Sunday October 23, 2022 @09:25AM (#33306813)
You don't need Jest. You can use buld-in test runner since Node 19.0 (https://nodejs.org/api/test.html)

1/ You do not need to use https / https module directly. You can use Fetch API since Node 17.5 ( https://nodejs.org/api/globals.html#fetch ).

2/ You do not need an external CLI parser. You can use build-in CLI parser since Node v18.3 ( https://nodejs.org/api/util.html#utilparseargsconfig )

Re:Curl doesn't add libproxy due to its quality issues by folkrav on Sunday October 23, 2022 @10:22AM (#33307237)
> You don't need Jest. You can use buld-in test runner since Node 19.0 (https://nodejs.org/api/test.html)

v19 was released 5 days ago. Barely had time to register this was a thing, let alone migrating our 3500+ unit test+ 300 integration test suite lol

> 1/ You do not need to use https / https module directly. You can use Fetch API since Node 17.5 ( https://nodejs.org/api/globals.html#fetch ). > 2/ You do not need an external CLI parser. You can use build-in CLI parser since Node v18.3 ( https://nodejs.org/api/util.html#utilparseargsconfig )

Lots of production environments tend to sit on latest LTS. v18 _just_ hit LTS, up to last month it was v16. Those weren't really an option for all these projects until then.

Re:Curl doesn't add libproxy due to its quality issues by lightswitch05 on Sunday October 23, 2022 @10:33AM (#33307321)
Yes, my library absolutely has to support the LTS version of Node, and I run the tests against all supported versions to ensure compatibility. So, one day I can use the nice things people are mentioning, but it will be years from now.
Re:Curl doesn't add libproxy due to its quality issues by jcpst on Sunday October 23, 2022 @09:43AM (#33306951)
I tried making a tiny test runner that printed nicely to the console. It’s very basic, but I was surprised at how little code it took: https://github.com/jcpst/neon-johnston/blob/master/test/inde...
Re:Curl doesn't add libproxy due to its quality issues by simplotek on Sunday October 23, 2022 @09:46AM (#33306972)
> I've written a library with zero production dependencies. Of course I have Jest as a development dependency which pulls in all sorts of stuff. It would be difficult to make a zero-dependency library.

That really depends on what your expectations and goals are. You mention Jest but as it's a test dependency then security is not a major concern, and thus it's ok to just vend the source code into your project trees.

Re:Curl doesn't add libproxy due to its quality issues by bombolo on Sunday October 23, 2022 @12:05PM (#33307961)
> No logging library. This one was pretty easy. Create a little class with logging levels.

Do you print to /dev/stdlog using the correct syslog format or use journald and its format?

Because if it's not one of those, the "levels" are useless.

Re:Curl doesn't add libproxy due to its quality issues by bornfreddy on Sunday October 23, 2022 @01:08PM (#33308459)
No, the levels are not useless, far from it. Even if you just print to stdout, prefixing each line with a (maybe colored?) level info is very useful. Also, if later you decide to use xyz format, it is trivial to implement this. Changing all logging calls? Not so much.
Re:Curl doesn't add libproxy due to its quality issues by bombolo on Sunday October 23, 2022 @05:32PM (#33310479)
Just use a real logging daemon and it will be the colours by itself.

It will also let you query for which level you want.

> Changing all logging calls? Not so much.

Uh? Make a good library using the same interface.

Re:Curl doesn't add libproxy due to its quality issues by lightswitch05 on Monday October 24, 2022 @12:26AM (#33312930)
To answer your question, the levels are important for both regular usage and debugging when something goes wrong. I create a number of debug/info/warning/error log messages throughout the tool and allow the desired level of logging to be set as a CLI argument - or even run in silent mode if desired.
Re:Curl doesn't add libproxy due to its quality issues by rockwotj on Sunday October 23, 2022 @08:52AM (#33306571)
For the most part, it's also really easy to add node dependencies compared to C/C++. Is it surprising folks take the past of least resistance?
Re:Curl doesn't add libproxy due to its quality issues by ushakov on Sunday October 23, 2022 @08:50AM (#33306562)
> To be fair, is there any other way around while working with node?

breaking robot noises

Re:Curl doesn't add libproxy due to its quality issues by pixl97 on Sunday October 23, 2022 @02:27PM (#33309033)
In reverse I've seen a banking apps pull in a gigabyte of node dependencies and am thinking there's no possible way they'll ever be able to validate the security of everything.
Re:Curl doesn't add libproxy due to its quality issues by fweimer on Sunday October 23, 2022 @09:42AM (#33306939)
For a generally usable implementation, libproxy needs to be able to process proxy auto-config (PAC) files, which are small (or not so small) Javascript programs. These programs are expected the parse the URL and decide which proxy server to use (or a direct connection). It's not declarative at all.

Therefore, libproxy is not a trivial dependency.

Re:Curl doesn't add libproxy due to its quality issues by vokspon on Sunday October 23, 2022 @12:00PM (#33307924)
True but curl wouldn't need to implement a particularly optimised JavaScript runtime to handle PAC programs, there would be no point in e.g. bundling V8 or ChakraCore with it.
Re:Curl doesn't add libproxy due to its quality issues by mmis1000 on Sunday October 23, 2022 @03:39PM (#33309597)
I think quickjs is invented for exact this type of usage. A properly implemented, speed-irrelevant, small runtime for embedded usage.

Most pac files are just a few lines and you don't really need a speedy runtime to run it.

Re:Curl doesn't add libproxy due to its quality issues by wkdneidbwf on Sunday October 23, 2022 @10:10AM (#33307152)
this is an inane comparison.
Re:Curl doesn't add libproxy due to its quality issues by ldoughty on Sunday October 23, 2022 @10:30AM (#33307303)
Well, yes....

In my general experience, "System Admins" have a security-first mindset along with years of focusing on how to maintain a secure system AND blessing from management to be slower for end-product reliability and security of business assets/data.

Developers, *who can certainly have this mindset and skill set as well*, are typically forced to be more business-oriented with management-dictated objectives/deadlines that more strictly limits their ability to invest the time, so you get "the best I can do in the allotted sprint/deadline time minus the other committed work I need to do".

So inevitably the application will let something through, and it becomes to System Admins' responsibility to protect the company... And that seems to be okay with most businesses.... Developers can move quick fast and dirty, and the operations/admins will try to limit the scope of the blast.

It adds several hours or days of work for a developer to add secret storing/retrieval/rotation compared to just hard-coding a key in the environment, so if they have 2 days to implement a feature, they are not going to spend 2 days implementing extra safeguards unless someone speaks up and pushes back (and the other side relents)

Re:Curl doesn't add libproxy due to its quality issues by pjmlp on Sunday October 23, 2022 @02:21PM (#33308999)
Which is why DevOps, sorry system admins, then have automated tooling for detecting those kind of workarounds, and then we get a sad developer that has to fix a broken pipeline deployment.

In case of places that take security seriously that is.

Re:Curl doesn't add libproxy due to its quality issues by shp0ngle on Sunday October 23, 2022 @10:57AM (#33307476)
Well, my application has no tests, badly designed API and no documentation too. So its fiiine
Re:Curl doesn't add libproxy due to its quality issues by pjmlp on Sunday October 23, 2022 @02:19PM (#33308986)
On most of the projects I am involved with, if the modules haven't been cleared for use, the CI/CD pipeline will fail, regardless of working on dev's machine.

If only all projects were as conscious.