We fixed f-string typos in popular Python repos

Re:We fixed f-string typos in popular Python repos by dekhn on Friday April 29, 2022 @03:05PM (#31209381)

I looked through all three. The first isn't really a complaint because the bot acted in good faith and found an error. In the second one they complained abiout a missing unsubscribe link (reasonable) and in the third one, the author should update their code so it doesn't create a variable named path, then a non-f-string that includes "{path}". I had to stare at the author's comment that it was a false positive for quite a bit to convince myself they were right.

[ Parent | on HN ]

Re:We fixed f-string typos in popular Python repos by vitus on Friday April 29, 2022 @03:33PM (#31209689)

I will point out that in the first two issues, the repo owners also edited the initial report with something along the lines of "removed ad".

I disagree that the first isn't a complaint -- the owner stated that this behavior isn't appreciated but decided to let it slide because the issue was valid.

In the third issue, the owner also explicitly stated: "I don't think bots posting unsolicited static analysis results are a good idea." I have no opinions on whether the code should be clearer, but that doesn't change the validity of the reaction.

[ Parent | on HN ]

Re:We fixed f-string typos in popular Python repos by klyrs on Friday April 29, 2022 @03:50PM (#31209860)

The bot-account's (apparently human-written) reply of "you're very welcome" to the complaint in the third issue is downright dismissive of the problem and kinda passive aggressive. While it seems that the bot did good work overall, the human(s) handling edge cases need work.

[ Parent | on HN ]

Re:We fixed f-string typos in popular Python repos by mhils on Friday April 29, 2022 @04:02PM (#31209988)

We've blocked the bot after their script malfunctioned and they opened a second issue with exactly the same text (https://github.com/mitmproxy/mitmproxy/issues/5286).

[ Parent | on HN ]

Re:We fixed f-string typos in popular Python repos by rikatee on Friday April 29, 2022 @04:31PM (#31210245)

klyrs was right about the reply from me (a dev behdind Code Review Doctor) being dismissive in the issue. I apologise for that.

FWIW my reaction was classic "expectations not meeting reality": weeks of work to do (what I thought) was a mutually beneficial helpful thing. I was naively not expecting non-positive responses and was ill prepared when you raised valid concerns I had not considered.

Again, I am working on that and sorry I was passive aggressive to you.

[ Parent | on HN ]

Re:We fixed f-string typos in popular Python repos by mhils on Friday April 29, 2022 @04:47PM (#31210396)

Thank you - that explanation makes sense, apology accepted. :)

[ Parent | on HN ]

Re:We fixed f-string typos in popular Python repos by scotty79 on Saturday April 30, 2022 @05:27AM (#31214579)

No good deed goes unpunished.

[ Parent | on HN ]

Re:We fixed f-string typos in popular Python repos by klyrs on Friday April 29, 2022 @06:16PM (#31211212)

Nice response, thanks.

[ Parent | on HN ]

Re:We fixed f-string typos in popular Python repos by dekhn on Friday April 29, 2022 @03:35PM (#31209711)

I do think the question of "how should bots that do static analysis work" is an important one, but in the meantime, people are gonna bot and repo managers are gonna complain.

[ Parent | on HN ]