One of my DIY projects was a couple smart plugs and a temperature sensor; at the peak of summer heat, when the house was hot but it cooled off at night, I automated ventilating our house. It had a great impact on our comfort without using air conditioning (which we didn't have). That is a decent use for this kind of stuff, but it's far too much effort for most people to go through.
Does everybody want to do that? No. How far do modern systems go towards achieving any of that? Ehh, IMO not very far unless you put a lot of effort into it. Do the UIs of modern systems really make setting up these sorts of complex interactions up accessible for the average person? Nope. Are there glaring privacy and security concerns? Yep. There are lots of perfectly valid criticisms, especially of "smart" homes as they are, but there are certainly lots of possibilities.
There is a bigger reason - what problem do they solve? How much money and/or time will using their products save me? The one area where there might be worthwhile savings is smart thermostats, but could 90% of those savings be accomplished with an offline thermostat with a timer?