If you're accessing the size of, say, a linked list, you end up sneaking an O(n^2) runtime because it has to re-count the size of the list every iteration to check for termination.
c.f. https://secure.wikimedia.org/wikipedia/en/wiki/Schlemiel_the...
I'd expect any decent linked list implementation to keep an integer with the current size. Java certainly does: http://www.docjar.com/html/api/java/util/LinkedList.java.htm...
You're still going to run in O(n^2) if you remove from the back (as you'd do if you run in reverse).
Linked list are far more efficient if you build in reverse but remove in iteration order (just replace your head pointer with head.next)
for(i = list.size; i >= 0; i--)
list.removeAt(i);
Is itself a schlemiel algorithm on any singly-linked list...Either way, we have just come up with 3 much clearer solutions in what I would guess is at most 5 minutes between us. I would guess we have the luxury of it not being 9pm at night and working for our jobs. I was happy to see the author include note of that rather than just call the original programmer an idiot for not knowing how to write maintainable code.
int c = this.MyControl.TabPages.Count;
for ( int i=0; i < c; i++ )
{
this.MyControl.TabPages.Remove ( this.MyControl.TabPages[i] );
}
Let's say you have 4 items. That'll go something like this: Original list: (0,1,2,3)
Remove 0 Item 0 removed, items (1,2,3) become (0,1,2)
Remove 1 Item 1 (originally 2) removed, items (0,2) become (0,1)
Remove 2 Only two elements left in the list (0 and 1), so there is no index 2 anymore...
To clean it up, I'd do 1 of 2 things: Either write a .clear() function, or rewrite it to start at the end and clear the items in reverse.
With the .clear() function, I can at least ignore it because it was tested and worked. (You do write tests, right?)
With it in reverse, it's something I've done numerous times because of how lists work in certain languages. I'd instantly recognize that it's going backwards because the list always starts at 0.
If I wrote it in reverse, I'd also write a comment about why it's in reverse, though, so that anyone else can instantly know why, as well.