Re:What's wrong with this code, really?
by wccrawford on Friday September 16, 2011 @09:40AM
(#3004387)
I'm sure we've all had our 'Why did I code that so badly???' moments. ;) I stopped getting mad at people for bad code quite a while back. It doesn't help either of us. Instead, I just fix it. The bonus to me is the little rush from improving something. Thank goodness for that little rush.
seems more like continuous rush :-(
This is broken in a different way (assuming you mean something like the following):
int c = this.MyControl.TabPages.Count;
for ( int i=0; i < c; i++ )
{
this.MyControl.TabPages.Remove ( this.MyControl.TabPages[i] );
}
Let's say you have 4 items. That'll go something like this: Original list: (0,1,2,3)
Remove 0 Item 0 removed, items (1,2,3) become (0,1,2)
Remove 1 Item 1 (originally 2) removed, items (0,2) become (0,1)
Remove 2 Only two elements left in the list (0 and 1), so there is no index 2 anymore...
Either way, we have just come up with 3 much clearer solutions in what I would guess is at most 5 minutes between us. I would guess we have the luxury of it not being 9pm at night and working for our jobs. I was happy to see the author include note of that rather than just call the original programmer an idiot for not knowing how to write maintainable code.