America still has more to offer than a lot of the world, but it's not some shining peak in a valley of despair - it's more "middle of the table, some good, some bad". If you're here already, it's easy to look out, see, and decide to move where it's better, if you can.
Me ? I'm a Brit, been living here for the last almost two decades. I came here for the money and the weather, nothing more. Recently, the weather is a bit crap; the money's still good, but once I get to where I can FIRE, I'm out of this country. There's plenty of places better.
Arguably the American Dream is very much intact, it's just that it's mostly brown & yellow people achieving it. I have a lot of friends who left their home country because there were no opportunities for them there, and now have the suburban house with a yard, 2 kids, white picket fence, neighborhood Trick'or'Treaters, good savings, and vacations whenever they need a break. They work very hard for what they have, which has always been part of the American Dream, but they get a good life in exchange for it.
1. People leave worse places (by some metric, usually poverty or opportunity) to come to US since its big and rich and full of potential. That is why immigrants come here. Its the richest big nation with lots of jobs. You can try to move to china or brazil or india which have massive populations, but the jobs pay better here. You can move to Switzerland or some EU nations that have higher avg salary, but the COL is high and immigration is even harder with less lucrative job openings available.
2. People leaving aren't the immigrants who arrived (not including returning to old country). People who "have the american dream of leaving" are the middle class white kids who don't see their own growth into top 10% of society (because they perceive their social mobility decreasing or gone), and see the exploding debt and health costs across america (often they haven't experienced directly), so they want to move to a socialized nation and "free healthcare". This is almost always a white euro nation, not eg. china or inida. Do they move? Not always.
TLDR. People still want to move to america, but some americans are basically chasing some ideal/privilege they think they can get better elsewhere.
Economic opportunities in america are great if you're willing to work your ass off and smartly. Smartly is the keyword to avoiding exploitation. That said, the wages here are way higher than in other countries. Here in Colombia, the minimum wage comes out to around $250/month. People here don't have much choice given the language barrier and lack of skills for the international market. Their skillset and ability to endure absolute crap gives them an edge when they immigrate to the US and get paid relatively descent wages for their work.
Now I'm on the other end. I have skills as a software engineer, fluency in english and connections. Those are all things I can take with me to maintain the smae wage I'd be making in america in a country where the average wage is a fraction of what I make. Thus I get to live like a king.
TLDR: both sides are moving to maximize their living potential and they increase for different reasons.
https://www.migrationpolicy.org/programs/data-hub/charts/top...