News for hackers. Stuff that matters.
Re:Ask HN: Is all code patchy and bad in FANG? by unanswered on Saturday October 09, 2021 @04:21PM (#28812927)
Yes, this is common. Frankly it was a bad idea to complain; you should be prepared to... be invited to leave your current position.

Here's why: Everyone (on the ground floor at least) knows that the code is terrible, but the organization is not optimizing for good code. Code quality is simply and literally a non-goal. The goal is to deliver Projects, where a Project is a unit of work which advances someone's career, whether it be an IC, a project/team lead, a project manager, etc. Now, it's okay not to internalize that goal for yourself; but you've exposed yourself as not understanding that this is the goal that everyone else has. Unfortunately, this makes you a liability w/r/t the goal.

There are ways to advance other goals in the organization, and I suspect these organizations only survive as long as sufficient people are doing just that, but they all revolve around making other goals coincide with The Goal described above.

Note that The Goal isn't a secret or taboo; it's explicitly acknowledged in some organizations. Not so long ago at Microsoft, for example, it is known as "impact" and is the explicit top-level metric for performance review. If you can figure out how The Goal it's expressed in your organization, you can attempt to rescue the situation by explaining that what you really meant was you want to advance The Goal (eg. "improve my impact") by delivering improved code quality in future projects which will have such-and-such an impact on visible metrics.

Re:Ask HN: Is all code patchy and bad in FANG? by throwaway_fred on Sunday October 10, 2021 @09:24AM (#28818234)
This resonates, I also suggested that I might not be a good fit as I dont think the result impact is there. This was probably not good career move here, as it is being discussed higher up. But I honestly am unable to create impact with this codebase. This could also just mean that I am not fit for the job and they need other people.

I do understand the goal tho, that's why I raised the issue that I cant deliver enough impact in my eyes. And I think it's the right thing to raise.

Thanks for your reply, it now makes sense that quality is not a goal. At my level I should be able to work with this instead of just complaining.

Re:Ask HN: Is all code patchy and bad in FANG? by Sevii on Sunday October 10, 2021 @08:31PM (#28823277)
FAANG wants people who can 'get things done' in the byzantine code bases that they maintain. That is why they pay so much and why turnover is so high.

Fundamentally fixing the problem is not necessarily possible. At FAANG basic things like maybe upgrading from Java 8 to Java 11 are three year 50 person projects.

Re:Ask HN: Is all code patchy and bad in FANG? by tdeck on Sunday October 10, 2021 @11:14PM (#28824262)
It's also very possible that you'd be happier and more effective on a different team at the same company. All of these companies are big enough to have a great diversity of systems, from nascent projects to polished but boring workhorses, to unmaintained balls of tech debt that they can't turn off but nobody wants to work in. Often if you want to influence the direction of a codebase, it's best to get in on a new project or system that's just being built.
Re:Ask HN: Is all code patchy and bad in FANG? by siproprio on Saturday October 09, 2021 @07:09PM (#28814170)
"Projects" are "something that advances someone's career"? I thought projects were "something which our client actually paid for and we're contractually obligated to fullfil"
Re:Ask HN: Is all code patchy and bad in FANG? by yen223 on Saturday October 09, 2021 @07:56PM (#28814439)
A bit of A, a bit of B. Successfully delivering a project that generates a lot of revenue is a great way to advance one's career.
Re:Ask HN: Is all code patchy and bad in FANG? by quickthrower2 on Saturday October 09, 2021 @10:13PM (#28815197)
Probably not for FAANG who tend to not have clients with custom contracts in general. Unless you are going to spend 20bn a year with Google I don’t think they care about you enough for a special contract with deliverables.
Re:Ask HN: Is all code patchy and bad in FANG? by siproprio on Saturday October 09, 2021 @11:50PM (#28815604)
I always included Microsoft in FAANG
Re:Ask HN: Is all code patchy and bad in FANG? by siproprio on Saturday October 09, 2021 @11:47PM (#28815592)
not for FAANG, but yeah, it's a pretty big engineering conglomerate
Re:Ask HN: Is all code patchy and bad in FANG? by jmole on Saturday October 09, 2021 @04:59PM (#28813251)
It really boils down to this: if it ain’t broke, don’t fix it.

If it is broken, and no one else seems to see that it’s broken, then it’s your job to convince everyone else that it’s broken so that “fixing it” becomes part of the The Goal.

Re:Ask HN: Is all code patchy and bad in FANG? by Aqueous on Saturday October 09, 2021 @05:37PM (#28813527)
Though this can also backfire. I observed a huge architecture error in the central data structure / schema of our system. Everyone agreed that it was a huge problem so I got put in charge of fixing it. Of course when you build an entire system around a bad schema, it gets baked through every inch of that system. Over a year later and it’s mostly fixed, but my career has stalled and I took the major hit to fix it.