News for hackers. Stuff that matters.

A comment on Terraform is currently not reviewing community pull requests. Parent comment

Re:Terraform is currently not reviewing community pull requests by geerlingguy on Sunday September 05, 2021 @10:10PM (#28429569)
There are many projects where just doing that would be the equivalent of a full time position. Even saying no requires a skilled review.
[ Parent | on HN ]
Re:Terraform is currently not reviewing community pull requests by loeg on Monday September 06, 2021 @01:03AM (#28430473)
If you are rejecting all PRs, that doesn't require skilled review -- a bot can do it.
[ Parent | on HN ]
Re:Terraform is currently not reviewing community pull requests by mgbmtl on Tuesday September 07, 2021 @08:40PM (#28451579)
A bot should do it. Because sometimes people throw a tantrum, so it's easier to just ignore a PR. Or a maintainer might post a quick reply, only to be bitten later on. I love and live by open source, but the drama can be exhausting.
[ Parent | on HN ]
Re:Terraform is currently not reviewing community pull requests by dtech on Monday September 06, 2021 @03:34AM (#28431359)
Are you really open source in spirit at that point though?
[ Parent | on HN ]
Re:Terraform is currently not reviewing community pull requests by nitrogen on Monday September 06, 2021 @03:42AM (#28431402)
Yes. Both the cathedral and the bazaar are valid approaches to OSS project management, with pros and cons.
[ Parent | on HN ]
Re:Terraform is currently not reviewing community pull requests by aesyondu on Monday September 06, 2021 @05:10AM (#28431814)
For those curious apart from myself:

Cathedral -> centralized control Bazaar -> decentralized control

https://opensource.stackexchange.com/questions/511/whats-the...

[ Parent | on HN ]
Re:Terraform is currently not reviewing community pull requests by Zababa on Monday September 06, 2021 @04:19PM (#28437599)
"open source" doesn't mean "accepting drive-by contributions from unknown authors". "open source" means "open source". If you want to apply your patches, you're free to fork the repo.
[ Parent | on HN ]
Re:Terraform is currently not reviewing community pull requests by amyjess on Sunday September 05, 2021 @11:22PM (#28429908)
Is there no way to just have a script add a comment on every new PR saying "Due to insufficient staff, your PR may not be reviewed for a considerable amount of time."?
[ Parent | on HN ]
Re:Terraform is currently not reviewing community pull requests by tmp538394722 on Sunday September 05, 2021 @11:32PM (#28429958)
Your code is important to us. Please stay on the line, and the next available reviewer will answer your code. Due to unusually high code volumes, this response may take longer than usual.

Something like that?

[ Parent | on HN ]
Re:Terraform is currently not reviewing community pull requests by tn1 on Monday September 06, 2021 @05:29AM (#28431931)
All that's missing is an autoplay embed with some hold muzak ;-)
[ Parent | on HN ]
Re:Terraform is currently not reviewing community pull requests by rob74 on Monday September 06, 2021 @04:59AM (#28431771)
I think the issue is about letting people know that PRs won't be reviewed/merged before they bother putting a lot of effort into them (both the commit itself and setting up/documenting the PR).
[ Parent | on HN ]
Re:Terraform is currently not reviewing community pull requests by tonyedgecombe on Monday September 06, 2021 @01:58AM (#28430824)
It would be nice if you could turn off accepting pull requests whilst keeping the project alive.
[ Parent | on HN ]
Re:Terraform is currently not reviewing community pull requests by remram on Tuesday September 07, 2021 @08:19AM (#28443775)
This has always been a weird quirk of GitHub. You can disable issues, boards, wikis, but pull requests cannot be toggled. It's a pain point for lots of projects: those closed to contributions, those which are not primarily code (issues-only), those that use a different platform for review (e.g. Gerrit), ...

Why does GitHub persist? It's not like forcing the feature enabled helps anyone. The maintainers will still not merge if they don't want to. There are bots in the marketplace that will close PRs with a message. GitLab has a toggle. Why is this so important to GitHub?

[ Parent | on HN ]