Systems like this are (IMO) great for doing proof-of-concept projects and development things where you are concentrating on other factors. Ex: if I enable my TV remote to operate my garage door, what should I use the Mute button for...
With these platforms (Arduino, BASIC stamp, etc.) you create a lot of "glue" between different devices and protocols, including getting samples from sensors, and so on without a lot of effort.
The down-side, as you note, is that for many many reasons they are unsuitable to build any kind of semi-commerical product around.
Going from Arduino prototype to real product is too vague of a question though. If your needs are simple, you might be able to use a handful of discrete components and 74xx series logic chips, or you might need to add in a PIC, or an Atmega chip, or whatever. But in almost every case you can put together a purpose built piece of hardware once you have your basic requirements fleshed out that is cheaper and easier to produce than a product built on top of the Arduino.
If at your entry point you're already thinking of a commercial or hobbyist product, it's probably better to skip the Arduino and either go straight to the chip (maybe get an Atmel Dragon development kit) or buy a cheaper board that has a bootloader and sample code.
At some point you're going to have to get comfortable with hardware, so Arduino won't buy you anything.
Edit: Nix that, just buy the Ardweeny: http://www.makershed.com/ProductDetails.asp?ProductCode=MKSB...
If you just want to plug a Gamecube controller into your computer this is probably a better option: http://goo.gl/Y0nP9
I didn't fully understand the ATMega bit, but I'm assuming it means I can even use the same C++ program and not have to rewrite it for a new chip? That would be an amazing way to go, if so. I had assumed I'd at least have to recompile for a different chip.
Edit: Looks like http://www.arduino.cc/playground/Learning/AtmegaStandalone explains it for me. Thanks for the tip! That's exactly what I needed to push me further.
Is there a pretty clear path from starting with a 'duino and moving to custom set of components (assuming we're not talking about anything crazy complex like making a smartphone lol) or would it be essentially re-learning everything from scratch?
For example, the other day I wanted to plug a GC controller into a USB port. I'm pretty sure I could wire it up to a programmable chip and make that happen. I'm also pretty sure an 'duino would be easier. But would making one version make it easier to make the other?