News for hackers. Stuff that matters.
Re:Open-source, not open-contribution by enriquto on Thursday January 28, 2021 @09:23AM (#25942112)
> Github really needs to allow people to disable the "Pull Request" tab on repos, to reduce the stigma around not accepting pull requests.

I'm not the one to defend GitHub, but what's the big deal about not accepting pull requests? If you clearly state that you won't accept PRs and somebody still sends them, then you can close them right away and problem solved. Am I missing anything?

Another issue is that the github pull request model is not very "gitonic". There are much saner systems like sourcehut.

Re:Open-source, not open-contribution by darkwater on Thursday January 28, 2021 @09:27AM (#25942170)
> Am I missing anything?

Yes. The "reduce the stigma" part. Having users open a PR to just get it automatically closed by a bot (which also needs to be set up) it's far less welcoming than NOT having at all a "Pull requests" tab where you can open said PR.

Re:Open-source, not open-contribution by alkonaut on Thursday January 28, 2021 @09:39AM (#25942352)
Most projects should have a readme and most readme's on github should have a constributing section that everyone hopefully reads before creating a PR. Failing to do so tbh means that person probably failed to comply with coding standards or whatever else is in there. It's just as likely to have the PR closed for those reasons as for the reason "No PR's please".

That said, I agree with the idea of simply removing the possibility to make external PR's. The possibility to view (internal) PR's must be there though, so that external viewers can see PRs from the mainainer(s).

Re:Open-source, not open-contribution by TheRealPomax on Thursday January 28, 2021 @12:31PM (#25945306)
You can't enforce a readme. If it says "PRs are not accepted", and you create a pull request template that says "please be aware your PR will get closed automatically", folks will still file PRs in the hopes that their work is special enough to consider, and they still get their hopes crushed when that their PR gets closed without ever having been looked at.
Re:Open-source, not open-contribution by filmgirlcw on Thursday January 28, 2021 @01:08PM (#25946072)
If someone either willfully or through purposeful negligence both doesn’t read a README or PR template that outline PRs aren’t welcome and submits a PR hoping against hope for a different outcome, I think we can assume that absolutely nothing will prevent them from having their hopes crushed.

I don’t think optimizing for that edge case makes a ton of sense. Having the ability to hide PRs might be a nice feature, but some people use that for stuff other than straight pull requests.

Re:Open-source, not open-contribution by kelnos on Thursday January 28, 2021 @04:56PM (#25949940)
It's not just about that, though. I want to avoid crushing people's hopes, yes, but in the event that they are absolutely set on submitting a PR, I don't want to have to deal with getting a notification and having to manually close it. (And no, I don't want to take the time to set up a bot to do it either. I have better things to do with my time.)
Re:Open-source, not open-contribution by filmgirlcw on Thursday January 28, 2021 @06:04PM (#25950813)
I mean, I get that, and I'm not opposed to having a method to turn off PRs. I'm just saying that if the impetus is avoiding crushing people's hopes because a README and template isn't clear enough, I think there are people that will still create an issue or send an email about why they can't submit a PR.
Re:Open-source, not open-contribution by TheRealPomax on Thursday January 28, 2021 @04:15PM (#25949331)
Then maybe those folks should get a better feature for that, too. More than one thing can be suboptimal about the same feature-as-implemented.
Re:Open-source, not open-contribution by filmgirlcw on Thursday January 28, 2021 @06:07PM (#25950835)
Totally valid, and I'm not opposed to an option to turn it off, I was just saying I can understand why some people might need to keep it on, even if they do have a README and PR template that makes it clear they don't accept PRs. I just think the "crushing the hopes of people that don't read" aspect is probably the lowest priority in that sort of situation.
Re:Open-source, not open-contribution by cutemonster on Thursday January 28, 2021 @08:25PM (#25952362)
That's not the only thing.

A few of those who didn't read the README, and get their PRs auto closed, might get upset at the maintainers, and write something a bit angry, making it less pleasant to be a maintainer.

Re:Open-source, not open-contribution by alkonaut on Friday January 29, 2021 @10:31AM (#25958238)
Enforcing the readme is simply closing/ignoring the PR's.

You can easily do that, but what you can't do is prevent people from being angry. You can do everything in your power to prevent people from accidentally wasting their time, and you should. This is where "hide the feature" would come in.

Re:Open-source, not open-contribution by yawaramin on Thursday January 28, 2021 @12:35PM (#25945373)
If there is one constant on the internet, it's that people don't read. You can say whatever you like, there will be tons of people who brush past it and just go and send PRs anyway.
Re:Open-source, not open-contribution by dialamac on Thursday January 28, 2021 @01:29PM (#25946496)
Then let them learn their lesson. The thing is I have done stupid shit due to carelessness, but I’m not so entitled to blame it on someone else. If a potential source code contributor cannot read the contributing guidelines AT ALL that is on them, lesson learned. Really fuck em if they’re gonna stay butt hurt about it.. this should have been cleared up in kindergarten.
Re:Open-source, not open-contribution by cutemonster on Thursday January 28, 2021 @08:22PM (#25952336)
Some of them might get upset at the maintainers tough, and write something a bit angry, making it less pleasant to be a maintainer

> Really fuck em if they’re gonna stay butt hurt about it.. this should have been cleared up in kindergarten.

Such an attitude from a maintainer can piss people of and make them write angry things to the maintainer, causing him/her to quit.

Re:Open-source, not open-contribution by Elhana on Thursday January 28, 2021 @10:07AM (#25942865)
Why not just leave them open for some other people who might find them useful, but never accepting them?
Re:Open-source, not open-contribution by gus_massa on Thursday January 28, 2021 @11:48AM (#25944668)
Ten year later someone will post it here, as a proof that the maintainer of the project is not doing his/her "job".

Also, I remember a case where after some time someone decided that since the maintainer was not answering, it was fine to add insults and threats.

Re:Open-source, not open-contribution by tshaddox on Thursday January 28, 2021 @03:47PM (#25948947)
Surely having a disabled or hidden pull request button is also very solid proof that the maintainer is not accepting pull requests.
Re:Open-source, not open-contribution by enriquto on Thursday January 28, 2021 @09:29AM (#25942206)
> it's far less welcoming

Oh please, only somebody with a ridiculously thin skin would be offended by seeing rejected his PR to a project that clearly states that does not welcome outside contributions.

Re:Open-source, not open-contribution by gregoriol on Thursday January 28, 2021 @09:53AM (#25942582)
The other day I opened an issue on a project to mention that the project is not respecting some powerful convention (by dumping stuff when the user's configuration is to not dump stuff), and the project maintainer replied by saying that he doesn't care... that he thinks his choice is better.

I'm quite angry because I spent time investigating this problem and now it won't be fixed and it is not logical and I've lost my time.

Re:Open-source, not open-contribution by jerf on Thursday January 28, 2021 @10:07AM (#25942861)
Don't underestimate that "fork" button. If the software otherwise does what you want, but you need some particular change, fork away.

Obviously one needs to be judicious with this, but I've scored some big wins from this. In addition to bypassing projects who don't want to accept the (IMHO) perfectly reasonable contributions, I've also some cases where the upstream project shouldn't accept my changes and I shouldn't submit them. I've got one case where I forked a package and essentially twisted it so hard that it destroys it for its original purpose, even though it now does exactly what I need. A couple of others where the upstream is obviously dead. Another case I can think of where in principle the upstream could accept it, but it adds a subtle and easy-to-misuse feature to the package that I understand fairly well having written it, but would really encourage users to mess themselves up and is hard to document properly, so I probably won't ever submit it.

It's not something I do all the time by any means... the above paragraph describes nearly all the cases where I've done it. It's 3 or 4 in as many years. But each of them was a fairly large win.

Re:Open-source, not open-contribution by MaxBarraclough on Thursday January 28, 2021 @12:44PM (#25945529)
> If the software otherwise does what you want, but you need some particular change, fork away.

You'll then have to maintain the fork, re-applying your changes whenever the upstream repo is updated

Re:Open-source, not open-contribution by type0 on Thursday January 28, 2021 @04:43PM (#25949735)
It might not work with big projects but libraries and other smaller software is perfectly fine.
Re:Open-source, not open-contribution by jerf on Thursday January 28, 2021 @03:17PM (#25948411)
Obviously, one needs to be judicious with this.
Re:Open-source, not open-contribution by dialamac on Thursday January 28, 2021 @01:34PM (#25946578)
Microsoft or Oracle will be glad to sell you something then. Geeze the babies around here.. not every project maintainer is going to agree with you as was apparently the crux of the original complaint. You don’t always get your way. And Apparently just having the ability to fork the source and do whatever the fuck you want is not enough for these pratts.
Re:Open-source, not open-contribution by shock on Thursday January 28, 2021 @10:15AM (#25943007)
Presumably the project you mention is open source, so you've not lost your time – the time spent investigating the issue puts you in a better position to fork the project an implement the change to your specifications without involving the maintainer.

I don't understand the anger, are you angry because he doesn't have the same opinion as you and doesn't want to make the implementation behave according to your opinion?

Re:Open-source, not open-contribution by whimsicalism on Thursday January 28, 2021 @11:08AM (#25944043)
> I'm quite angry because I spent time investigating this problem and now it won't be fixed and it is not logical and I've lost my time.

I guess the lesson is that there is always someone angry over something unreasonable.

Re:Open-source, not open-contribution by mitjak on Thursday January 28, 2021 @11:01AM (#25943912)
it's.. not your project. if you disagree, fork away. your anger is on you.
Re:Open-source, not open-contribution by afarrell on Thursday January 28, 2021 @09:37AM (#25942322)
You are free to disbelieve the answer, but it still stands.
Re:Open-source, not open-contribution by DangitBobby on Thursday January 28, 2021 @09:36AM (#25942304)
Depends on how much work they put in, doesn't it?
Re:Open-source, not open-contribution by tombot on Thursday January 28, 2021 @09:48AM (#25942494)
Surely someone invested enough to submit a PR would have read the readme which explains they won’t accept a PR
Re:Open-source, not open-contribution by folkrav on Thursday January 28, 2021 @10:01AM (#25942762)
Reading stories from open-source maintainers, I have 0 difficulty believing many would not.
Re:Open-source, not open-contribution by qhwudbebd on Thursday January 28, 2021 @10:03AM (#25942793)
I really wish that were true!
Re:Open-source, not open-contribution by onion2k on Thursday January 28, 2021 @09:35AM (#25942288)
only somebody with a ridiculously thin skin...

People like that are very common and often very vocal.

Re:Open-source, not open-contribution by rectang on Thursday January 28, 2021 @09:37AM (#25942321)
> Am I missing anything?

In order to keep the IP for a project pristine (for the sake of downstream users), I would prefer never to see somebody else's copyrighted solution to a problem. If I see their contribution but I don't want to accept it, I'm forced to come up with a new creative solution that a court would (maybe, hopefully) consider original.

This is especially important for CC0/public-domain projects, where many contributors will not fully understand the implications of contributing and may not be in a position to release code into the public domain.

Re:Open-source, not open-contribution by enriquto on Thursday January 28, 2021 @09:40AM (#25942380)
> I would prefer never to see somebody else's copyrighted solution to an issue

You are doomed, then. They can always sent a (unrequested) email to you, Cc'd to a public mailing list. The PR interface is just another equivalent way for people to send messages to you, like email.

Re:Open-source, not open-contribution by rectang on Thursday January 28, 2021 @09:52AM (#25942567)
Somebody's really going to have to go out of their way to email a patch — they might even read the `CONTRIBUTING` document which says "Thanks but no!".

The Github Pull Request interface is an attractive nuisance, like an unfenced swimming pool. You can't keep people out with warning signs, they won't read them. Put up a fence, though, and even the obtuse will get discouraged.

Re:Open-source, not open-contribution by kelnos on Thursday January 28, 2021 @04:55PM (#25949914)
> * If you clearly state that you won't accept PRs and somebody still sends them, then you can close them right away and problem solved. Am I missing anything?*

I don't want to have to set up an auto-close bot when I should be able to just untick a checkbox in the project's settings.

I don't want to have to click through PR notifications and manually close them when I should be able to just untick a checkbox in the project's settings.

Re:Open-source, not open-contribution by Stratoscope on Thursday January 28, 2021 @02:57PM (#25948128)
> Another issue is that the github pull request model is not very "gitonic". There are much saner systems like sourcehut.

That is an interesting observation. Can you elaborate on what you mean? Thanks!

Re:Open-source, not open-contribution by bmn__ on Friday January 29, 2021 @04:24AM (#25955558)
Read https://blog.brixit.nl/git-email-flow-versus-github-flow/ and lots of articles by ddevault/sircmpwn about git-send-email on various discussion boards including HN.