Whatever happened to the concerns around Apple selling in China and what compromises they may have made for that?

Google doesn't sell data, it sells targeted access to users based on that data. Let's be precise if we're going to discuss the practical privacy implications of both platforms.

Meanwhile if you use iCloud backups all your data is one subpoena away from law enforcement.

Correct. But why does google deserve to know everything about you? What does it matter if they can still browse everything about you and they happen to resell targeting. All still bad. I agree the Warrentless wiretaps are a problem for every American company, google included.

My point stands, apples revenue is not from privacy violating advertising and has no motivation for data collection beyond product improvement

Apple took a 9 Billion dollar payment from Google in 2018 for Google to be the default search engine [0].

[0]: https://dazeinfo.com/2018/10/01/apple-google-fee-iphone-sear...

This doesn’t refute the parent.

iOS 14 also makes app ad tracking opt-in, Google would never.

China :)

Apple also makes money by selling their users to Google to do all that nasty stuff.

No, they really don't.

Remember the fun we had making fun of Apple Maps? Why in the world would Apple have dropped Google as the back end for their original Maps program, right? Well, it was because back in 2011 or so, Google refused to give Apple access to true turn-by-turn navigation features unless Apple gave them more access to user data. Rather than do that, Apple decided to go it themselves, even though that made the Maps product worse for years. This is consistent with Apple's behavior in other fields. (Hey, Siri!)

There are a lot of criticisms to be made of Apple, but "they're selling your data by proxy" just doesn't seem to be one of them.

They really do. Check the other comment on this thread.