News for hackers. Stuff that matters.
Re:GitHub isn't fun anymore by tzs on Wednesday June 17, 2020 @01:57AM (#23548246)
Before adding the newest fad features, maybe the should go back and add old fads that they missed.

One big fad from 50+ years ago that I'd welcome is folders. I don't want to just have all my repositories appear in a flat list ordered by time since last update. I want to make folders so I can organize repositories by topic--just like I have my repositories organized in my computer.

Re:GitHub isn't fun anymore by threeseed on Wednesday June 17, 2020 @03:01AM (#23548596)
My favourite fad of the last few decades is: sorting.

You know because in Github you can't even sort your list of repositories.

Re:GitHub isn't fun anymore by 6510 on Wednesday June 17, 2020 @05:59AM (#23549662)
HTML cant even sort
Re:GitHub isn't fun anymore by threeseed on Wednesday June 17, 2020 @07:24AM (#23550149)
It sort of can with the Flexbox order property.
Re:GitHub isn't fun anymore by tirpen on Wednesday June 17, 2020 @08:31AM (#23550580)
Neither can jpg.
Re:GitHub isn't fun anymore by Wingy on Wednesday June 17, 2020 @07:16AM (#23550103)
JS can though, so can Ruby.
Re:GitHub isn't fun anymore by 6510 on Wednesday June 17, 2020 @07:55AM (#23550328)
It doesn't belong there in my view.

We started out not knowing what anything should look like, we didn't even know what computers were suppose to do. Everything had to be envisioned and implemented. Different approaches were taken for a lot of things. Eventually we just know how something should work. At that point it can be abstracted away.

Similarly lots of things should stay in JS. If we've experimented and evolved to the point where we know how something should work we should grow beyond modules and have build in methods for it.

It is happening but much to slow in my opinion.

Say, we have a Date API, are week numbers a thing or not? Are they an unpredictable poorly understood thing? Does it bother anyone if the API supports it?

Everything should be able to migrate up and down from the metal to the highest level of abstraction depending on how much we use it.

edit: There is no point shipping [table] sort magic to the client on every page view that needs it.

Re:GitHub isn't fun anymore by chipotle_coyote on Wednesday June 17, 2020 @12:16PM (#23553129)
It seems like you're simultaneously saying "sorting doesn't belong as a language function in JavaScript" and "we shouldn't ship a sorting routine to the client," which seems...odd. If the page view needs sorting, then isn't that the use case where we can most say that there is, in fact, a point to "shipping sort magic to the client"?

(Also, you can do an HTML table sort in about 10 pretty short lines of code[1], so this seems like a kind of weird hill to die on.)

[1]: https://stackoverflow.com/questions/14267781/sorting-html-ta...

Re:GitHub isn't fun anymore by 6510 on Wednesday June 17, 2020 @03:08PM (#23555419)
JS should have an array sort function. HTML should have sort-able tables. We know what they look like. We shouldn't have to pump up our pages with a bazillion lines of js just to implement something entirely obvious.

IOW: If there is a table it doesn't hurt to be able to sort it by default.

The example is great! 10 lines... no wait... 30 lines... then you have something that... or no wait, it sorts numbers alphabetically. The cursor is wrong. There is no accessibility. The little arrows are missing ▲ ▼ did I pick the right ones? They look bulky, better add another span inside the th? Oh I clicked the th twice now the text is highlighted.

Why should I need to implement this myself? I'm not inventing anything new? I don't want to be dealing with colspan but we all know how it should work? I know its wrong but I usually leave out the <thead>, tables render just fine without it but when something generates tables like that the script needs to be re-examined to figure out why it doesn't work. There is some unknown number of other ways to break it.

A default implementation could deal with some common units out of the box. Monday could go in front of Tuesday, 50 cm could be smaller than 1 m, $100 could be bigger than $20. Just the simple obvious stuff. For everything else something like <th sort="foo"> with: foo = (a,b) => a.length - b.length

List items are a bit less obvious but I'm sure we can think of something sensible. Perhaps sorting by child class?

What is the drawback?

Re:GitHub isn't fun anymore by throwaway8941 on Wednesday June 17, 2020 @03:00AM (#23548589)
JFYI, they have those in gitlab.

Here's an example.

https://gitlab.com/gitlab-org

Re:GitHub isn't fun anymore by melenaos on Wednesday June 17, 2020 @06:57AM (#23549991)
Ye, bit its not GitHub ;)
Re:GitHub isn't fun anymore by Grimm1 on Wednesday June 17, 2020 @08:26AM (#23550525)
Exactly ;)
Re:GitHub isn't fun anymore by smcg on Wednesday June 17, 2020 @10:25AM (#23551772)
not everyone gets a choice in tools...
Re:GitHub isn't fun anymore by Grimm1 on Wednesday June 17, 2020 @10:57AM (#23552188)
but many do.
Re:GitHub isn't fun anymore by kerng on Wednesday June 17, 2020 @02:14AM (#23548327)
The modern version is tags, but they lack good sorting/viewing for tags
Re:GitHub isn't fun anymore by raxxorrax on Wednesday June 17, 2020 @03:35AM (#23548829)
Not wanting to start a discussion about graphs vs trees for organizing, but in my opinion simple folders are great to fulfill basic needs. I cannot imagine a book having no table of contents and just a list of tags with numbers indicating relevant page numbers.

That is just dumbing yourself down in favor of machine classification or search algorithms while a simple solution exists for this problem for higher order classification and context, which tags alone fail to provide, even with sorting.

Re:GitHub isn't fun anymore by rytis on Wednesday June 17, 2020 @03:44AM (#23548886)
Depends on a book type I suppose. Most have "index" section, which is just a list of tags. In recipe books I find it more useful than ToC actually.
Re:GitHub isn't fun anymore by l72 on Wednesday June 17, 2020 @08:15AM (#23550446)
I think it depends on your goal. If I want to browse new chicken recipes, I am going to open the table of contents, find the section on poultry and start flipping through recipes. On the other hand, if I want to cook a chicken curry, I am going to go to the index and look up curry, then find the relevant page.

Folders are great for when you don't know what you want and just want to browse or explore based on broad topics. Tags/indexes are better when you know basically what you want, and you just need a way to find it or items similar to it.

Re:GitHub isn't fun anymore by 6510 on Wednesday June 17, 2020 @06:13AM (#23549749)
Al entry should go in a single category, chapter or folder. The index should provide a useful overview. Tags you may have in any amount. More is usually better.

A tag with a single entry is useful. Chapters should never have a single entry.

Re:GitHub isn't fun anymore by 6510 on Wednesday June 17, 2020 @06:08AM (#23549714)
With limited entries of text or code you can just have them all on one page. Slightly more requires a folder or category system. If you have even more you need tags you should also keep the categories (everything must sit in a single category), If you have even more you need categories, tags and search. Trying to use one of those for the wrong volume just creates clutter.
Re:GitHub isn't fun anymore by prepend on Wednesday June 17, 2020 @07:07PM (#23557899)
It’s surprising to me that they don’t just do a folder based view using tags and relationships among tags.

I don’t like being restricted to single folders, but I’d love to symlink projects into multiple folders.

This would work out well if they just added some graph functionality among tags.

Re:GitHub isn't fun anymore by atq2119 on Wednesday June 17, 2020 @05:39AM (#23549552)
This so much. Another pet peeve of mine: GitHub is terrible for the workflow that Git was originally designed for. Specifically, the issue that there's no good way to review patch series. The key here is presenting a series of patches as a whole, but allowing reviews on individual commits of the series.
Re:GitHub isn't fun anymore by cxr on Wednesday June 17, 2020 @11:53AM (#23552840)
This is my second or third biggest problem with GitHub. If I want to submit a patch—the thing that Git was made for—I cannot use GitHub to do it. Assuming one has already gone through the "create a GitHub account" step, my closest option is to go to github.com to create a completely unnecessary on-GitHub "fork", go back to my local copy to add that remote and push to it, and then go back to the github.com and click around to submit a pull request.

Pull requests in Git were designed for trusted, frequent collaborators. I.e., project maintainers that are routinely syncing with one another. It's not supposed to be the preferred mechanism for ordinary contributions, and certainly not for drive-by contributions.

My biggest gripe, though, is that the on-GitHub fork from the first paragraph will live on in my namespace forever, unless I manually prune it. And even if I do prune it, I still have no way to control the fact that GitHub has silently set up a social networking timeline to broadcast a centralized index of all this activity to anyone and everyone, without asking me, and without a way to manage the stuff that goes into the timeline, control who it's shared with, or turn it off completely.

Re:GitHub isn't fun anymore by infinitezest on Wednesday June 17, 2020 @06:45AM (#23549931)
Assuming that we're talking about the same thing, this is possible in GH from the `Files` tab on the PR screen.
Re:GitHub isn't fun anymore by u801e on Wednesday June 17, 2020 @08:32AM (#23550592)
Not really. You cannot comment on the commit message itself. And, if I'm not mistaken, changes made in one commit that are undone in a subsequent commit won't show up even if the files view if filtered by commit.

Also, it's difficult to tell which comment is associated with which commit.

Re:GitHub isn't fun anymore by conradludgate on Wednesday June 17, 2020 @09:02AM (#23550830)
I don't think I ever factor in commit messages into my code reviews. I may look at the commit history if I want to see how they experimented implementing the feature, but I only care about the end goal and the code I will be merging in at the end.
Re:GitHub isn't fun anymore by u801e on Wednesday June 17, 2020 @10:26AM (#23551794)
The issue is that Github actually discourages reviewing by commit because it makes it difficult to do so. Though there are those who are only interested in the overall diff, there are others who want to be able to maintain a clean and informative history via version control. When the review system makes it difficult to ensure that's the case, then then version control history cannot be maintained.
Re:GitHub isn't fun anymore by atq2119 on Wednesday June 17, 2020 @04:43PM (#23556485)
Precisely. We're in a vicious cycle where most people using Git don't use what ought to be Git best practices for most serious large scale projects (clean history with self-contained logical commits and good commit descriptions) because GitHub makes it so difficult to do this. And to be fair, GitLab really isn't much better in this department.

And there isn't enough pressure on GitHub or GitLab to clean up their act because most people don't even know what they're missing. And so the cycle continues.

Re:GitHub isn't fun anymore by felipelemos on Wednesday June 17, 2020 @07:08PM (#23557913)
If you use squash and merge this won't be a problem, you will have a "clean history with self-contained logical commits and good commit history", and intermediary commits won't matter anyway.
Re:GitHub isn't fun anymore by u801e on Wednesday June 17, 2020 @11:37PM (#23559574)
Some features take more than a single logical commit to implement. Looking at the git mailing list, I see patch series containing anywhere from 1 to 10 commits (with some as many as 15 commits).

Also, having a single commit touching many parts of the code makes it harder to revert due to a greater chanche of conflicts with other commits.

Re:GitHub isn't fun anymore by ashtonkem on Wednesday June 17, 2020 @08:40AM (#23550662)
I’ve recently switched from GitLab to Github enterprise due to a job switch. I am shocked at how bad Github enterprise is to navigate. It seems like I regularly have to depend on the search function to find the repo I want.
Re:GitHub isn't fun anymore by mbeex on Wednesday June 17, 2020 @06:35AM (#23549869)
So, something like https://docs.gitlab.com/ee/user/group/ ? But this is gitlab.
Re:GitHub isn't fun anymore by kreddor on Thursday June 18, 2020 @08:53AM (#23562605)
I agree completely. I miss folders for YouTube subscriptions as well. It seems folders are on the way out in most modern tools and apps.