Yes he did. No doubt about that. 3 Billion USD worth arms deal is definitely not the true potential of the Indo-US Strategic Defense Partnership though. It can be so much more! But it is a good start. It can be sped up if US can relax its norms in relation to transfer of technology.
The Rafale deal which India signed was a 7.87 Billion Euro deal [1]. India is going to modernize its defense capabilities this decade and this is the right time for the United States to relax its norms if it wants to be a major player. Especially with Make in India being given a thrust in Defense sector.
[1]: https://economictimes.indiatimes.com/news/et-explains/rafale...
I think Trump succeeded in that. Other than that, I don't think he succeeded at anything, if you can call that a win ;)
One of the better side effects of Trump is that the world has gained by finally stepping away from US reliance... American hegemony is no longer.
(Basically, it's designed with that as a top goal. Be simple/cheap to work on.)
Traditionally, I think the primary reason to buy US fighter jets at very high prices compared to the non-US competition has been that you also expect to get some amount of military protection back from the US worth much more (like 5-10x more) than that investment. Trump has turned this scheme upside down. We thank him for this.
(I also happen to think it may end up being a good thing for the US. It's cutting off a lot of the money supply to the US military complex. Isn't that a good thing?)