News for hackers. Stuff that matters.
Re:LightSpeed: Rewriting Messenger’s codebase for a faster, ... by fao_ on Monday March 02, 2020 @09:45PM (#22471351)
From TFA: "We reduced core Messenger code by 84 percent, from more than 1.7M lines to 360,000."

Sounds like not only did they make the app quicker and lighter, they improved code maintenance too. If the android app is as the same size as the new ios messenger app, they'd still have less code to maintain than the previous ios messenger app.

See also: this other comment - https://news.ycombinator.com/item?id=22468036

Re:LightSpeed: Rewriting Messenger’s codebase for a faster, ... by hvidgaard on Tuesday March 03, 2020 @01:51AM (#22472381)
How in the name of everything did they manage to write 1.7M lines of code for a messenger app? That is an astonishingly large code base! We're talking about an instant messenger app with heaps of features, having a LoC footprint 3.5% of the size of modern Windows.
Re:LightSpeed: Rewriting Messenger’s codebase for a faster, ... by tasogare on Tuesday March 03, 2020 @03:40AM (#22472882)
> Since then, we’ve added payments, camera effects, Stories, GIFs, and even video chat capabilities

Simple: they added tons of crap nobody care. On this list, I only use video. Messenger is valuable because of the network effect, but feature wise 2003’s MSN was good enough.

Re:LightSpeed: Rewriting Messenger’s codebase for a faster, ... by SifJar on Tuesday March 03, 2020 @07:31AM (#22473887)
> nobody care

> _I_ only use

(emphasis added)

Just because you don't use those features, doesn't mean nobody cares about them

Re:LightSpeed: Rewriting Messenger’s codebase for a faster, ... by hvidgaard on Tuesday March 03, 2020 @03:54AM (#22472933)
None of that justifies 1.7 million LoC.
Re:LightSpeed: Rewriting Messenger’s codebase for a faster, ... by Ayc0 on Tuesday March 03, 2020 @08:59AM (#22474441)
That's not true, the application, whether you like or not, it full of micro-interactions, well-done animations and transitions, features like the payment or stories, you can take photos directly from the app, etc.

With that many features, it doesn't surprise me that the previous codebase was 1.7M LoC. Sure if you count only the messaging part, I'm fairly certain that the LoC is way lower than this.

It doesn't make sense to compare the number of LoC of messenger to the number of LoC of software like Postgres because Postgres tries to be good at 1 thing and messenger tries to have a ton of features with good UI and UX.

I don't like many of their features (I'm not using the stories or the payment), but some of my friends do and you have to recognize the work that the messenger team did to make them work that well.

Re:LightSpeed: Rewriting Messenger’s codebase for a faster, ... by throwaway55554 on Tuesday March 10, 2020 @04:30PM (#22539353)
Don't forget all the code to support A/B testing.
Re:LightSpeed: Rewriting Messenger’s codebase for a faster, ... by Gene_Parmesan on Tuesday March 03, 2020 @03:05PM (#22478256)
One of their points in the article was how they've decided to use more of the native OS interfaces instead of implementing their own versions (!!). For instance, using the OS's native threading library instead of writing their own. So, the number of LoC kinda start to make sense when you think about them re-implementing some not-trivial chunk of an OS's native functionality.
Re:LightSpeed: Rewriting Messenger’s codebase for a faster, ... by ashishb on Tuesday March 03, 2020 @06:55AM (#22473651)
LOC is proportional to the number of engineers on a project. All engineers have to justify their existence, so, they will write code.
Re:LightSpeed: Rewriting Messenger’s codebase for a faster, ... by therealdrag0 on Tuesday March 03, 2020 @11:29AM (#22475944)
I've never felt the need to justify my own existence. There's always been a longer backlog of work than my teams would ever get through and managers who appreciated the work getting done.

Another plausible explanation is lack of code re-use and reinventing the wheel because you don't know someone else solved the same problem. Also correlates with number of engineers.

Re:LightSpeed: Rewriting Messenger’s codebase for a faster, ... by philips4350 on Tuesday March 03, 2020 @02:23AM (#22472521)
I wonder if react native library code and all the other code related to it like the js engine is included in that metrics.
Re:LightSpeed: Rewriting Messenger’s codebase for a faster, ... by danabramov on Tuesday March 03, 2020 @05:10AM (#22473214)
There was no React Native in the Messenger app before the rewrite.
Re:LightSpeed: Rewriting Messenger’s codebase for a faster, ... by philips4350 on Tuesday March 03, 2020 @06:57AM (#22473667)
Oh my bad, i thought all facebook apps used react native
Re:LightSpeed: Rewriting Messenger’s codebase for a faster, ... by FunnyLookinHat on Tuesday March 03, 2020 @09:17AM (#22474583)
I had the same question... And that's not counting LOC on the server. And all of this is for... glorified text messaging, right? I don't use FB so I could be missing context or features.
Re:LightSpeed: Rewriting Messenger’s codebase for a faster, ... by azinman2 on Tuesday March 03, 2020 @02:22AM (#22472507)
And they ended up in hundreds of thousands of lines :)

Wonder if part of this is custom video / audio codecs? That I’d imagine would contribute a good amount...

Re:LightSpeed: Rewriting Messenger’s codebase for a faster, ... by toastal on Monday March 02, 2020 @11:50PM (#22471873)
I wonder how this will effect Lite. I use it over Messenger strictly to reduce bloat and get an app with the bare essentials of chat and calls fol friends that refuse to use Signal.
Re:LightSpeed: Rewriting Messenger’s codebase for a faster, ... by flucivja on Tuesday March 03, 2020 @10:59AM (#22475575)
I'am curious if in 360K LOC are also included templates configurations stored in SQLite because these must be written and maintained too.