Gitmoji – Yay or Nay?

Re:Gitmoji – Yay or Nay? by fbnlsr on Wednesday December 11, 2019 @03:32AM (#21760630)

Wait, I thought the goal of it is not to write emojis per se but rather use the shortcodes. That way, it's readable even when emojis cannot be rendered and it even makes search easier. So a typical commit message would read like that:

`:bug: Fix login modal`

It doesn't break anything and when interpreted (github, gitlab, gitkraken, etc...) it displays a nice looking emoji.

[ Parent | on HN ]

Re:Gitmoji – Yay or Nay? by MivLives on Wednesday December 11, 2019 @09:11AM (#21762462)

This is how Slack and I believe Discord handle emojis as well. Interestingly even if you copy and paste a unicode emoji it's translated into a code.

[ Parent | on HN ]

Re:Gitmoji – Yay or Nay? by bitcoinofficial on Wednesday December 11, 2019 @06:26AM (#21761502)

Doesn't 'fix' already mean there was a bug, that was 'fix'-ed?

[ Parent | on HN ]

Re:Gitmoji – Yay or Nay? by fbnlsr on Wednesday December 11, 2019 @08:20AM (#21762066)

A better example would be:

`:lipstick: Revamp login modal`

[ Parent | on HN ]

Re:Gitmoji – Yay or Nay? by Liquidor on Wednesday December 11, 2019 @06:37AM (#21761544)

> Doesn't 'fix' already mean there was a bug, that was 'fix'-ed?

Read this: https://stackoverflow.com/questions/3580013/should-i-use-pas...

TLDR from the Git repo: Describe your changes in imperative mood, e.g. "make xyzzy do frotz" instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy to do frotz", as if you are giving orders to the codebase to change its behavior.

People have different opinions on what tense to use, but the one that scales better would be in imperative mood. See example here: https://github.com/facebook/react

[ Parent | on HN ]

Re:Gitmoji – Yay or Nay? by SifJar on Wednesday December 11, 2019 @08:27AM (#21762115)

I don't think this answers the question?

[ Parent | on HN ]

Re:Gitmoji – Yay or Nay? by Liquidor on Thursday December 12, 2019 @07:24AM (#21771232)

How come? As I understand the comment, the user is questioning the tense of "fix" and I'm providing a reason and an example as to why someone would use imperative mood in their commit message.

Edit: Nevermind. I must have been tired yesterday. User wasn't questioning the tense, but pointing out that the part of the message "fix" making the :emoji: redundant.

[ Parent | on HN ]

Re:Gitmoji – Yay or Nay? by kickopotomus on Wednesday December 11, 2019 @12:16PM (#21764518)

Agreed. I think this actually argues in favor of using a [fix] tag over [bug].

[ Parent | on HN ]