News for hackers. Stuff that matters.

A comment on Ask HN: How to improve code quality while maintaining decent velocity?.

Re:Ask HN: How to improve code quality while maintaining dec... by dominotw on Tuesday December 10, 2019 @08:27AM (#21752200)
> rejected as it did not meet the required standards.

can you give us some examples of this? Do you agree that your design didn't meet the standards?

Its entirely possible that your new team is being mean to you, I'v seen team politics play out in PR reviews.

[ Parent | on HN ]
Re:Ask HN: How to improve code quality while maintaining dec... by benignslime on Tuesday December 10, 2019 @08:53AM (#21752387)
Yeah the only way OP will get accurate advice is with an example or two. From my experience, always expect some nasty PRs in the beginning. Just because someone hired you doesn't mean you're entitled to respect, and many teams will make you earn it.
[ Parent | on HN ]
Re:Ask HN: How to improve code quality while maintaining dec... by hnaccy on Tuesday December 10, 2019 @12:45PM (#21754721)
>From my experience, always expect some nasty PRs in the beginning. Just because someone hired you doesn't mean you're entitled to respect, and many teams will make you earn it.

Sounds pretty toxic tbh.

[ Parent | on HN ]