News for hackers. Stuff that matters.
Re:Tips for reviewing code you don’t like by Double_a_92 on Monday July 08, 2019 @10:45AM (#20383148)
Agree. I'm not trying to do the reviewer a favor, nor are they asking one from me.

Even if it's some personal style thing, I don't perceive "Could you...?" as rude or anything.

If anything an exaggerated please could seem more insulting, as in "Could you please just do this simple thing ffs!?"

Re:Tips for reviewing code you don’t like by santoshalper on Monday July 08, 2019 @10:59AM (#20383281)
Part of functioning well in groups is understanding that not everyone shares your specific quirks - everyone has their own weird shit.

Of course, trying to accommodate everyone's unique perspective and behaviors would never scale, so instead we fabricate social norms that represent a sort of common denominator of human behavior. Part of these social norms are manners and polite behavior. These act as a sort of protocol for human interaction.

This all a long way of saying that even though you may think saying "please" is condescending or implies a favor, you are almost certainly in a vanishingly small minority and this will not serve you well socially.

I am trying to give you some insight into why you struggle with social interactions and often rub people the wrong way without intending to or even realizing it. My strong recommendation is you be polite even when you think you don't need to be.

Re:Tips for reviewing code you don’t like by nroach on Monday July 08, 2019 @10:58AM (#20383270)
Tolerance for and expectation of "please" can be cultural. OS code may receive contributions from global contributors.

Anecdotally, in my team which spans individuals from each continent except Africa and the poles, US english speakers are the least likely to use 'please', whereas our APAC (asia-pacific) contributors use it liberally.

Re:Tips for reviewing code you don’t like by Double_a_92 on Tuesday July 09, 2019 @02:16AM (#20389392)
Was i was trying to say was mainly that saying please implies that what is asked is more of a personal taste, and not an objective thing that really should be fixed.

If it's really something subjective I would say "This would be nicer if..." or "I think that could be changed to..." Instead of formulating some almost passive-aggressive request with "please".

Re:Tips for reviewing code you don’t like by marcus_holmes on Monday July 08, 2019 @07:10PM (#20387631)
or SE Asian team members who say "yes boss, sure" and then do nothing... and then you find they disagreed with the thing you proposed but there's no way in their culture that they can disagree with the boss, so they just say yes and do nothing. That one was fun to deal with ;)
Re:Tips for reviewing code you don’t like by wolco on Monday July 08, 2019 @12:38PM (#20384174)
Canadians will use it liberally along with thanks.
Re:Tips for reviewing code you don’t like by sverige on Monday July 08, 2019 @01:42PM (#20384904)
And sorry.