Please do not attempt to simplify this code

Re:Please do not attempt to simplify this code by hodgesrm on Thursday December 27, 2018 @08:42PM (#18774252)

I really enjoyed the Ousterhout book as well. It's my current user manual for reviewing pull requests.

Putting my PR reviewer hat on I would say the code in question would pass muster if it were relatively stable so you would not be constantly redoing the comments. I love nice comments but Golang does not give you much help keeping them in sync.

(Weirdly enough I'm working on a PR for persistent volume documentation at VMware today so the code is very apropos.)

[ Parent | on HN ]

Re:Please do not attempt to simplify this code by AlexCoventry on Thursday December 27, 2018 @10:31PM (#18774703)

> Golang does not give you much help keeping them in sync.

What do you have in mind, here? Something like python's doctest?

[ Parent | on HN ]

Re:Please do not attempt to simplify this code by hodgesrm on Friday December 28, 2018 @11:51AM (#18777853)

Javadoc. It generates warnings if method argument documentation does not line up with the method signature, for example.

[ Parent | on HN ]

Re:Please do not attempt to simplify this code by scns on Friday December 28, 2018 @04:26AM (#18775762)

Elixir tests code in comments for correctness

[ Parent | on HN ]