Is there anything Apple could have done to protect the privacy of its Chinese users better (whilst still having some)? You could say they shouldn't have Chinese users, but that's a different argument, I believe.

This is false. iCloud data doesn't contain phone call contents or iMessage data contents. Yes they gave access to metadata, but this is China where privacy basically doesn't exist, not a western country.

Wrong - Apple moved all iCloud data, which includes text messages, email and other data stored in iCloud (according to Reuters) as well as the access keys. Apple even forced users to sign the updated TOS or drop service.

The Chinese government access is _not_ limited to metadata.

https://www.reuters.com/article/us-china-apple-icloud-insigh...

Text messages are not stored in iCloud...

https://support.apple.com/en-us/HT202303

>iCloud data doesn't contain phone call contents or iMessage data contents.

Literally the first paragraph of both of bduerst's links suggest otherwise.

Also, I don't know if you've used iCloud on multiple devices before, but it very much contains iMessage data contents.