Re:Code review review is the manager’s job
by emodendroket on Wednesday August 15, 2018 @09:11AM
(#17765730)
It's also easy for code review to devolve into "this isn't quite the way I'd implement it; scrap all this work and start over"
[ Parent
| on HN ]
Re:Code review review is the manager’s job
by nevir on Wednesday August 15, 2018 @09:36AM
(#17765897)
In a lot of cases, I see variations of this when there was not enough up front thought put into the design (before writing code).
Slight tangent, but a good way to tackle that is to outline what you want to do (sketch the API you're going to fill in, etc), and run that by a reviewer
Re:Code review review is the manager’s job
by emodendroket on Wednesday August 15, 2018 @09:38AM
(#17765905)
In a dysfunctional enough culture there's always someone you didn't include who has a show-stopping objection.
Re:Code review review is the manager’s job
by lighthazard on Wednesday August 15, 2018 @09:13AM
(#17765743)
That's not a code review. That's either a suggestion that the initial commit is 'wrong' or the reviewer is a jerk. Either way, this is the PM's fault - not enough information to finish it right or too reviewer nitpicky on useless stuff.
Re:Code review review is the manager’s job
by hyperpape on Wednesday August 15, 2018 @12:38PM
(#17767390)
There's a really good code review guide on the plaid blog that addressed this: https://blog.plaid.com/building-an-inclusive-code-review-cul....
Money quote: "Nothing should be surprising to a reviewer in a code review: discuss any significant design decisions before code is written. Code reviews are a time to iron out implementation details, not discuss major design or architecture decisions."
What if you use pull requests to prototype architectural change? My take is your pull request should include the context of the change and the sort of feedback you want.
Re:Code review review is the manager’s job
by hyperpape on Wednesday August 15, 2018 @07:28PM
(#17770638)
I think that explicitly noting “this isn’t ready, but I’d like to discuss x,y,z” ought to cover it.
Re:Code review review is the manager’s job
by emodendroket on Wednesday August 15, 2018 @09:31AM
(#17765862)
It was pretty common at my last job; seemed like every third PR got at least one request for a total or near-total rewrite, usually for completely non-functional changes without obvious benefits over the solution implemented.
Re:Code review review is the manager’s job
by jschwartzi on Wednesday August 15, 2018 @10:28AM
(#17766227)
I've been asked to make my solution more complicated and to add usage of things like the friend keyword to unit tests instead of testing a public static function.