News for hackers. Stuff that matters.
Re:Code review review is the manager’s job by emodendroket on Wednesday August 15, 2018 @09:31AM (#17765862)
It was pretty common at my last job; seemed like every third PR got at least one request for a total or near-total rewrite, usually for completely non-functional changes without obvious benefits over the solution implemented.
Re:Code review review is the manager’s job by jschwartzi on Wednesday August 15, 2018 @10:28AM (#17766227)
I've been asked to make my solution more complicated and to add usage of things like the friend keyword to unit tests instead of testing a public static function.