News for hackers. Stuff that matters.
Re:Code review review is the manager’s job by hyperpape on Wednesday August 15, 2018 @12:38PM (#17767390)
There's a really good code review guide on the plaid blog that addressed this: https://blog.plaid.com/building-an-inclusive-code-review-cul....

Money quote: "Nothing should be surprising to a reviewer in a code review: discuss any significant design decisions before code is written. Code reviews are a time to iron out implementation details, not discuss major design or architecture decisions."

Re:Code review review is the manager’s job by lox on Wednesday August 15, 2018 @05:20PM (#17769885)
What if you use pull requests to prototype architectural change? My take is your pull request should include the context of the change and the sort of feedback you want.
Re:Code review review is the manager’s job by hyperpape on Wednesday August 15, 2018 @07:28PM (#17770638)
I think that explicitly noting “this isn’t ready, but I’d like to discuss x,y,z” ought to cover it.