News for hackers. Stuff that matters.
Re:Building an Inclusive Code Review Culture by mnarayan01 on Monday July 30, 2018 @12:50PM (#17645855)

  if a = foo()
versus:

  if (a = foo())
Sometimes idiomatic patterns vary based on things which are not amiable to mechanical correction.
Re:Building an Inclusive Code Review Culture by quxbar on Monday July 30, 2018 @12:58PM (#17645945)
The trick is to ban even the correct but (to a human) ambiguous patterns. In this case, I wouldn't let you do assignment on the same line as the conditional.
Re:Building an Inclusive Code Review Culture by squiggleblaz on Monday July 30, 2018 @09:34PM (#17649857)
With an `if` it's probably superfluous and therefore bannable without cost, but sometimes it can make a `while` loop so much more concise - since the alternative would be to write the same code before the loop and at the bottom of the loop. It is the cost of inexpressive languages.
Re:Building an Inclusive Code Review Culture by fipple on Monday July 30, 2018 @02:08PM (#17646596)
In what language do those produce different results?
Re:Building an Inclusive Code Review Culture by mattnewton on Monday July 30, 2018 @04:42PM (#17647839)
In many people’s head-parser, the first one looks like an equality check (but is in fact assignment). The parens try to clue people into “this is an assignment expression!” I think, but personally I wouldn’t allow an assignment expression in an if statement even with parens.
Re:Building an Inclusive Code Review Culture by munchbunny on Monday July 30, 2018 @12:54PM (#17645892)
While you have a point, I don't think the exception should disprove the rule. Even if a few specific style patterns can't be automated, the bulk can be and it's probably better to have them enforced at the pre-compile stage.