News for hackers. Stuff that matters.
Re:Building an Inclusive Code Review Culture by quxbar on Monday July 30, 2018 @12:58PM (#17645945)
The trick is to ban even the correct but (to a human) ambiguous patterns. In this case, I wouldn't let you do assignment on the same line as the conditional.
Re:Building an Inclusive Code Review Culture by squiggleblaz on Monday July 30, 2018 @09:34PM (#17649857)
With an `if` it's probably superfluous and therefore bannable without cost, but sometimes it can make a `while` loop so much more concise - since the alternative would be to write the same code before the loop and at the bottom of the loop. It is the cost of inexpressive languages.