Since Apple music's family service wasn't compatible with how we use our devices, we cancelled Apple Music and got a family account on Spotify instead. When Apple Music expired it wiped all the playlists we had in iTunes including ones I created years before Apple Music was ever a thing and not even containing any music from Apple Music.
I'm thinking of also dumping iCloud, but I really like the automatic backing up of all our photos to all of our devices. Heck, at this point I would switch to Android as well if it weren't for the years of apps I've purchased for Apple and don't want to buy again.
Here's how to get back to where you were, if you want to use separate iCloud accounts.
1. On your device create create a Shared photo album. 2. Share it with your wife using her new iCloud ID 3. Select the photos that you wan to share (basically all of them initially) 4. Tap Share > iCloud Photo Sharing 5. Select the shared album.
From then on, you and your wife share all photos you want to share to to that Album.
Same thing works with shared Calendars, Notes, To-do list etc.
If you share an iCloud account across multiple people you will find yourself fighting the system all the time
Adding my own experiences with iTunes-wiped devices and music-collections...
The only consistent thing with Apple and music/services is them accidentally wiping or deleting your data from both your devices and their services.
Applied this consistently, it's clearly a design decision.
What kind of company designs things to behave this way? Really?
Perhaps the design decision assumes the separation is due to a divorce? In that case, keeping them separate is a reasonable decision since neither party would want to be forced to endure further shared memories on any device.