Re:How I review code
by benji-york on Wednesday January 24, 2018 @09:03AM
(#16222678)
This "oh crap" effect is one of the reasons I like "self review" as the first step in a code review process.
That is, go over the diff and add commentary explaining to the reviewer why you made particular changes (not explaining what the changes do, that should be in comments in the source).
That is, go over the diff and add commentary explaining to the reviewer why you made particular changes (not explaining what the changes do, that should be in comments in the source).