Re:How I review code
by benji-york on Wednesday January 24, 2018 @09:03AM
(#16222678)
This "oh crap" effect is one of the reasons I like "self review" as the first step in a code review process.
That is, go over the diff and add commentary explaining to the reviewer why you made particular changes (not explaining what the changes do, that should be in comments in the source).
Re:How I review code
by MaxBarraclough on Wednesday January 24, 2018 @10:05AM
(#16223196)
GitHub supports posting comments to a commit. Might be a good fit.
And most often of all, while explaining what they've done, the reviewee will say "and this does... oh crap, wait" and fix the mistake themselves. Among all their other virtues, a code reviewer is a level 2 debugging duck. (Although all of my code review experience is with buddy check-in style reviewing rather than sending it off to be reviewed. I can understand endless nitpicky questioning being annoying if you're doing it offline.)