How I review code

Re:How I review code by fouc on Wednesday January 24, 2018 @03:16AM (#16221169)

You probably need to get everyone on the same page on the coding idioms and style.

Personally I find that non-idiomatic code can be a bit distracting when I'm trying to evaluate the code for its overall approach and architecture.

[ Parent | on HN ]

Re:How I review code by pqh on Wednesday January 24, 2018 @07:39AM (#16222224)

And if people are writing 150 character plus lines, those are really, no joke, a lot harder to read. If the line is going to break anyway, why not just break it yourself at a spot that makes sense?

[ Parent | on HN ]