Re:ECMAScript 2017 Language Specification
by nathancahill on Tuesday July 11, 2017 @12:24PM
(#14745458)
Your linter will also complain about modifying newObj within the reducer.
[ Parent
| on HN ]
Re:ECMAScript 2017 Language Specification
by paulddraper on Tuesday July 11, 2017 @12:38PM
(#14745605)
Which a problem with using linters, not with programming.
Spread syntax should cover linter issues
Object.entries(obj).map(...).reduce((acc, [prop, value]) => ({...acc, prop:value}))
Re:ECMAScript 2017 Language Specification
by Rotten194 on Tuesday July 11, 2017 @12:39PM
(#14745620)
isn't that hideously inefficient? you're making a new object each iteration.
But purity.
it's very unlikely this is going to be the bottleneck in your application
Re:ECMAScript 2017 Language Specification
by mintplant on Tuesday July 11, 2017 @02:53PM
(#14746926)
I wouldn't be so quick to write that off as a performance concern. Creating tons of unnecessary objects is JavaScript's equivalent to programming without regard for cache locality at a lower level, due to the way the JITs work.
It's very unlikely you'll get any benefit from doing it the inefficient way either. Does eslint not support "ignore this part" comments?
Yes it does
// eslint-disable-line your-rule-to-ignore
In those cases, I usually use
Object.assign(acc, { [prop]:value })
While not sure if `[prop]` is better or worse than not creating a new interstitial object.why not just use acc[prop] = value ?
Re:ECMAScript 2017 Language Specification
by elmigranto on Wednesday July 12, 2017 @09:33AM
(#14752354)
Assignment does not return `acc`.
Which linter rule is that?
Re:ECMAScript 2017 Language Specification
by mirekrusin on Tuesday July 11, 2017 @01:35PM
(#14746134)
The one that doesn't like modifying function arguments?
Usually that only disallows reassignment of function arguments. For example, eslint's no-param-reassign rule by default allows modifying the properties of the function argument. However, the "props" parameter for this rule can disallow even the modification of properties of a function's argument.