News for hackers. Stuff that matters.
Re:Turning Off GitHub Issues (2016) by BugsJustFindMe on Tuesday May 23, 2017 @05:57PM (#14405730)
> Think you found a bug? Fork the repo, add a failing test

Ugh. No. 999 times out of 1000, the person maintaining the code actually knows what it does and how it works. And if I'm not that person, I don't. I found a problem. The problem affects me. It also probably affects other people.

I'm an intelligent, capable, curious, knowledgeable, and caring professional software developer. I write code for fun, but I write _my_ code for fun. And after that I don't have the energy or the inclination to learn how your shit works deep down where it matters. Because what will take you a minute, will take me a month unless I stop going to work every day.

I will do my best to describe what I was doing when the problem occurred, what I expected to happen, and what happened instead, but screw you if you think I need to understand your codebase or your testing infrastructure in order to report a problem.

Re:Turning Off GitHub Issues (2016) by robotresearcher on Tuesday May 23, 2017 @06:14PM (#14405846)
Do whatever you want.

But if the developer who gave you the fruits of their labour for free proposes a way to report bugs that works best for them, take it or leave it, or recommend a different approach in a civil tone if you must. But 'screw you'? Not classy.

Also, many Github-hosted projects are critical infrastructure for some people. They will make it as easy as possible for the developer to fix their bugs, if they are rational.

Re:Turning Off GitHub Issues (2016) by BinaryIdiot on Tuesday May 23, 2017 @06:19PM (#14405890)
> But 'screw you'? Not classy.

To be fair that's exactly the tone I read the gist in as well. It seems a bit overly hostile to users who may have questions or suggestions but either don't or cannot contribute code for whatever reason.

Emotional comments beget emotional comments.

Re:Turning Off GitHub Issues (2016) by robotresearcher on Tuesday May 23, 2017 @06:25PM (#14405925)
That's very true. But the relationship between developer and user is not symmetrical. I'll give the grumpy developer a pass that grumpy end user didn't earn.

Fielding a few hundred rude and entitled support requests for your free software can make anyone grumpy. Once you have a few thousand users your inbox is a source of frequent misery.

Re:Turning Off GitHub Issues (2016) by BinaryIdiot on Tuesday May 23, 2017 @06:44PM (#14406050)
> But the relationship between developer and user is not symmetrical.

I disagree. I see them as identical. Yes you're offering a free product but it's still a product, even if you don't want to call it one. The developers are your users. They are the ones using it. But even a developer may not know how your code works well enough to submit a PR.

> Fielding a few hundred rude and entitled support requests for your free software can make anyone grumpy. Once you have a few thousand users your inbox is a source of frequent misery.

For sure but I don't know how you avoid this without also isolating yourself from likely valuable feedback / information. Similar to fielding customer requests for a product a good 96% of the ideas / things customers want are going to be a terrible idea.

If I've learned anything from running products it's this: make it as stupid easy as possible for your customers to give you feedback / get ahold of you. When you do that you're going to get an absolute ton of noise but the bits of signal hidden in there can be amazing and you'll be able to directly help those along the way. From there it's learning how to manage the flow of information coming to you and trying not to take the bad personally (which is very hard to do when it's your baby / code).

Re:Turning Off GitHub Issues (2016) by robotresearcher on Tuesday May 23, 2017 @06:52PM (#14406112)
You are completely right. No argument.

It's still nasty to be rude to a developer instead of offering politely worded advice.

Re:Turning Off GitHub Issues (2016) by BinaryIdiot on Tuesday May 23, 2017 @07:59PM (#14406523)
Fair enough
Re:Turning Off GitHub Issues (2016) by scrollaway on Tuesday May 23, 2017 @06:52PM (#14406118)
> Fielding a few hundred rude and entitled support requests for your free software can make anyone grumpy.

Work smart, not hard. If you're getting a lot of support requests (entitled or not), add a paid support option. If you have so much traction already that you constantly have to deal with "hundreds of issues", you're well past the point where you should have done that.

Re:Turning Off GitHub Issues (2016) by BugsJustFindMe on Tuesday May 23, 2017 @06:35PM (#14405995)
> 'screw you'? Not classy.

Then, fine, tone police, I'm not classy.

I am, however, a FOSS developer who understands the value of non-technical contributions to a project.

Know which kinds of bugs don't get fixed? The ones your users never tell you about because you decided to make it hard to report them.

Re:Turning Off GitHub Issues (2016) by scrollaway on Tuesday May 23, 2017 @06:48PM (#14406086)
A thousand times this. Issues are generally a favour your user is doing you and your project. Yes, sometimes they're a waste of time; it's fine to close them if they are, it takes exactly one click to do so. Most of the time however, they're valuable even if you don't fix them: Other devs might see them and fix them for you.

In almost all cases, turning issues off is incredibly counter-productive.

Re:Turning Off GitHub Issues (2016) by guelo on Tuesday May 23, 2017 @07:44PM (#14406463)
> the person maintaining the code actually knows what it does and how it works

But apparently they're not allowed to decide what works best for their project as far as bug reports.

Re:Turning Off GitHub Issues (2016) by robotresearcher on Tuesday May 23, 2017 @07:00PM (#14406166)
I agree with your argument completely.

Just be nice, and your accurate advice is more likely to be useful. That's all.

Re:Turning Off GitHub Issues (2016) by BugsJustFindMe on Tuesday May 23, 2017 @07:04PM (#14406194)
> Just be nice, and your accurate advice is more likely to be useful. That's all.

https://en.wikipedia.org/wiki/Tone_policing

My advice is already useful. If someone chooses not to take it because they'd rather tell non-technical users to pound sand, then I hope their project suffers for it.

Re:Turning Off GitHub Issues (2016) by robotresearcher on Tuesday May 23, 2017 @07:09PM (#14406231)
There is an obvious meta comment to make here that I leave as an exercise for the reader.
Re:Turning Off GitHub Issues (2016) by BugsJustFindMe on Tuesday May 23, 2017 @07:17PM (#14406290)
Nah, you're probably mistaken.
Re:Turning Off GitHub Issues (2016) by Touche on Wednesday May 24, 2017 @08:59AM (#14409658)
I'd wager that 75% or more of GitHub projects are things like libraries, not end-user applications. So most people using GitHub are technical users.
Re:Turning Off GitHub Issues (2016) by ucarion on Tuesday May 23, 2017 @06:24PM (#14405914)
"I found a bug and you won't consider it unless I phrase it as example code? Screw you, I won't report it then!"

This seems like a reasonable thing to think and say.

A better alternative to the article's suggestion is to state somewhere that it is very likely your issue won't be considered unless it takes the form of a PR. The maintainers, if they don't want to deal with the bug, will say "could you make a PR with a failing test case? Otherwise I don't have the time to work on this".

That way, those who really want the bug fixed have to put in work, but those who just noticed a problem and are kind enough to let the maintainers know can do so easily. Why discourage bug-reporting?

Re:Turning Off GitHub Issues (2016) by dragonwriter on Tuesday May 23, 2017 @07:41PM (#14406442)
Perhaps most importantly, having the issue there let's some other interested user see it and put the effort in to repro the bug and do the test case or demonstrative example.
Re:Turning Off GitHub Issues (2016) by robotresearcher on Tuesday May 23, 2017 @06:28PM (#14405962)
I think I covered that in 'recommend a different approach in a civil tone if you must'.

It's the 'screw you' that put my back up.

Re:Turning Off GitHub Issues (2016) by Retra on Tuesday May 23, 2017 @07:06PM (#14406207)
To be fair, that 'screw you' was offered behind a predicate.
Re:Turning Off GitHub Issues (2016) by chc on Tuesday May 23, 2017 @08:07PM (#14406562)
That doesn't help much, seeing as the predicate is essentially "… if you don't want to do free debugging work for me as well as the free development work you're already doing."
Re:Turning Off GitHub Issues (2016) by Retra on Tuesday May 23, 2017 @09:43PM (#14407001)
Nobody said you have to actually fix the errors, only allow them to be reported. (Which GitHub makes pretty effortless, as I understand it.) At least then someone might be able to volunteer to fix it for them, especially if it is a serious or common problem.
Re:Turning Off GitHub Issues (2016) by scrollaway on Tuesday May 23, 2017 @06:42PM (#14406032)
Issues are fine. You don't need to tackle them, they're not an obligation - you don't have a contract with your users saying you'll fix their issues. If that's something you want, then say so in your README; corps will always be happy to pay for high quality code and support.

Most people freaking out about being burned out by their open source stuff are generally people who don't open source their stuff. Most open source projects, even very good ones, get very little traffic therefore very few issues. If you can't deal with the occasional email once every few months, turn notifications off.

> But 'screw you'? Not classy.

Saying "Write a test" is essentially saying "screw you". Github has been a blessing, in that it greatly lowered the barrier of entry in filing an issue with a project. It's a blessing for users and it's also a blessing for maintainers if you know how to deal with the influx of issues. Increasing the barrier of entry again is not the solution.

When I myself find bugs I'll certainly PR a fix if I'm able to (and have the time); but I often can't. Most of the time, because the development environment is unknown to me and I have no way to even run the tests (if there are any), let alone write one. So asking someone to get involved and up to speed with a project to the point that they're able to do this, before they can even file an issue with a screenshot that says "the padding looks bad on firefox", that's nonsense. It's even more nonsense when this is just a pet project of yours that most people will not care about.

IMHO, "this is stuff we do give away for free" is an excuse that's too often passed around. It is always true that projects you push to Github for free come with no obligation to care about it, its issues or the pings and cries for help from your desperate potential users. However, you lose the ability to say you're a good open source citizen and you're "giving things away".

A real-world parallel I can make is to the people giving their old/smelly/crappy/torn/bad clothes to charity shops and feeling ever so good about themselves. It's cool you have good intentions, but it's not charity if it ends up in the bin anyway.

Disclaimer: 99% of my work is open source and ends up on Github. A bunch of it sucks and when issues come up, I ignore them or write a 10-second close-reply. A bunch of it is good and I actually care about; and if I care about it, I'm not going to turn off issues just to make myself feel better about having an already-perfect project.

Re:Turning Off GitHub Issues (2016) by cgag on Tuesday May 23, 2017 @08:16PM (#14406605)
This post just seems like it's trying to class-up a screw-you to their users. I'd prefer people just keep it crude like this rather than try to make it sound like it's somehow a nice thing to do.
Re:Turning Off GitHub Issues (2016) by nperez on Tuesday May 23, 2017 @06:52PM (#14406107)
So you take code you don't understand and don't want to understand, and you use it to power someone else's business? Doesn't sound safe or professional to me. You don't need to understand everything about every dependency, but you should absolutely be willing to dig in a little
Re:Turning Off GitHub Issues (2016) by BugsJustFindMe on Tuesday May 23, 2017 @07:00PM (#14406164)
> So you take code you don't understand and don't want to understand, and you use it to power someone else's business?

This is what we call a strawman. Also, I guarantee that you do exactly what you're glibly dismissing every day of your life.

Re:Turning Off GitHub Issues (2016) by rocky1138 on Tuesday May 23, 2017 @07:58PM (#14406517)
Yeah. I mean, taken to the nth degree, even driving a car is doing that. Surely the parent gets on a bus, drives a car, rides a bicycle, etc.
Re:Turning Off GitHub Issues (2016) by shusson on Tuesday May 23, 2017 @07:01PM (#14406170)
> So you take code you don't understand and don't want to understand, and you use it to power someone else's business? Doesn't sound safe or professional to me

That attitude sounds crippling to being productive. At some point you have to trust code based on usage, brand, peer-reviews etc.

Re:Turning Off GitHub Issues (2016) by makomk on Tuesday May 23, 2017 @07:19PM (#14406303)
Aside from the fact that everyone relies on code that they don't understand, looking at the code probably isn't going to tell you all that much about how it's meant to work, which is rather important when trying to fix a bug.
Re:Turning Off GitHub Issues (2016) by vxNsr on Tuesday May 23, 2017 @07:12PM (#14406258)
Just ran into this at work, I have a manger who was maintaining an internal app and he asked me to take over because there was a bug and he was transitioning away from the techinicial aspects of his job. Anyway like, 2 days later he asks if I've fixed it yet. No I haven't fixed your cobbled together app that has no comments and generic variable names.
Re:Turning Off GitHub Issues (2016) by nine_k on Tuesday May 23, 2017 @07:12PM (#14406255)
If you can reproduce an issue with your code, you mostly have a failing test already. The open-source product in question seems to be a library.

For a command line tool you can write a shell script demonstrating the problem.

Re:Turning Off GitHub Issues (2016) by blazespin on Tuesday May 23, 2017 @06:12PM (#14405830)
You're being sarcastic, right? This is OS. It's fundamental underpinning is that if you want to use it (or at least engage its maintainers), you have to care.

That being said, maybe there could be a "found problem, not sure is a bug" flag that defaults to on. Or a warning dialog that says "without example code or detailed repro, this issue probably won't be looked at."

Re:Turning Off GitHub Issues (2016) by BugsJustFindMe on Tuesday May 23, 2017 @06:19PM (#14405884)
> You're being sarcastic, right? This is OS. It's fundamental underpinning is that if you want to use it (or at least engage its maintainers), you have to care.

Ugh.

My partner, who doesn't know the first thing about code, understands the value of FOSS. Caring about FOSS doesn't fix bugs.

A month ago (more?) I encountered a bug in LibreOffice Writer, which I use because it's really good, where track changes on a docx file wasn't working properly in a particular situation involving the deletion of tracked comments across saves.

QUICK! Find the line of code that caused it! Find the mechanism for creating a test case! I'll wait here.

Back here in the real world I was able to report the bug and have it fixed by someone who knows what the code does.

Re:Turning Off GitHub Issues (2016) by blazespin on Friday May 26, 2017 @01:44PM (#14425854)
You're confusing an application versus an API which is what this thread was about.
Re:Turning Off GitHub Issues (2016) by tinus_hn on Tuesday May 23, 2017 @06:40PM (#14406023)
You can't really compare a huge end-user product to a developer library though. Developers are supposed to be able to write code.
Re:Turning Off GitHub Issues (2016) by BugsJustFindMe on Tuesday May 23, 2017 @06:47PM (#14406076)
The world isn't all NPM left-pad modules. Code is arbitrarily complex.
Re:Turning Off GitHub Issues (2016) by cortesoft on Tuesday May 23, 2017 @07:33PM (#14406396)
There are libraries that are as complex as a large end-user product.
Re:Turning Off GitHub Issues (2016) by yjftsjthsd-h on Tuesday May 23, 2017 @11:38PM (#14407446)
Don't stop there: plenty of libraries are more complex than the applications using them. More complex, more general, used by more people. I mean, just libc and curl probably dwarf most applications that consume them.
Re:Turning Off GitHub Issues (2016) by tinus_hn on Wednesday May 24, 2017 @07:37AM (#14409209)
> ... turned off github issues on one of his smaller projects. ...