News for hackers. Stuff that matters.
Re:How terrible code gets written by sane people by kol on Sunday February 19, 2017 @04:05PM (#13681981)
I wrote two mails yesterday which basically "push back against upper management", for a very good reason. At least that's what I think. Now I'm totally terrified about what will happen tomorrow. I have 4 kids and almost no money in the bank.
Re:How terrible code gets written by sane people by edblarney on Sunday February 19, 2017 @11:39PM (#13684334)
Don't 'push back'. That is the wrong terminology, and it's inherently confrontational.

Explain to your managers the range of outcomes and give them the power to make the decision with the best information you can provide them.

i.e. 'if we skip this bit, then quality will likely suffer, with these kinds of expected outcomes'.

Don't be dramatic or emotional, just try to give the best information you can.

Also have sympathy for them - money does not grow on trees - and basically balancing quality vs. time-to-market is a constant and difficult challenge.

This way - if they decided to 'rush' it - they know what the likely outcomes will be and the inherent outcomes.

If they are making the decision then the responsibility falls on them to the extent that you have provided them with thoughtful and realistic assessment.

Re:How terrible code gets written by sane people by watwut on Monday February 20, 2017 @04:15AM (#13685734)
Pretty much this. Sometimes pushing back is needed, but way more often "negotiation" is needed. It is unreasonable to expect managers to magically see into the development details, you have to explain, made plans transparent etc etc. When you do that you often (not always) find that requirements are negotiable and not equally important, e.g. it is possible to meet the deadline without sacrificing code quality. Oftentimes the compromise is possible - you wont get two week straight of refactoring, but they are ok with using 20% of development time for cleanups.

I have seen developers "push back for the right thing" in a way that basically amounted to angry emotional outburst over things manager did not understood. The dude thought he is pushing for the right thing, but everyone else thought he does not listen to their needs, refuses to follow the company vision of the product replacing it by his own. (They wanted simplest possible functionality and fast, he was constantly adding own requirements to "make it better". When the same person pushes for yet another refactoring, management does not trust him.)

The other thing to understand is that some experienced lead remembers teams that were given time, no deadlines and all the good stuff and then produced mess anyway, procrastinated and took long time to do it. I have seen that happen and I have also seen that ended in long wars over petty differences in style and opinions. Sometimes the mess is result of people doing something knew and thus bad decisions along the way. Code review alone wont solve that, because the reviewer may be the one forcing mistake on others.

You need to communicate in the way that will ensure the manager that he or she is not in the above situation.

Re:How terrible code gets written by sane people by edblarney on Monday February 20, 2017 @12:18PM (#13688983)
There should be no need for 'wars' or even 'negotiation'.

It's the managers decision - not the developers, really.

The devs can lay out what can be done, and describe what the results will be if various paths are chosen.

'Skip the tests' - you get quality issues, but better schedule.

'Write perfect code' - you get quality, but it could take to long.

The old saying: 'fast' 'quality' or 'cheap' -> pick 2.

If your team is having problems because of bike-shedding over details, or messed up code - this is altogether another issue and needs to be addressed differently.

Re:How terrible code gets written by sane people by michaelbuckbee on Monday February 20, 2017 @01:00AM (#13684706)
I think you're laying out what is absolutely the best approach.

If you're an employee it's sometimes hard to separate the company's interests from your own, so I sometimes do a mental exercise I call "playing consultant" - where it's purely my job to "consult".

I try to honestly describe the options, give my best recommendation and then whatever they choose is on them.

Re:How terrible code gets written by sane people by dbmikus on Sunday February 19, 2017 @06:48PM (#13682982)
As long as you're tactful and willing to cede your argument if they don't come to see your side, there shouldn't be any reason to be terrified. If you act diplomatically and still have crazy bosses, might be good to find a different job if you can, or just not care and get your paycheck.
Re:How terrible code gets written by sane people by jaxn on Sunday February 19, 2017 @07:59PM (#13683370)
Unfortunately it is not that simple. Sometimes pushing back on the management is an indication of misalignment of priorities. It may not happen right away, but it can definitely limit your tenure.

I have been on both sides of this.

Re:How terrible code gets written by sane people by dbmikus on Monday February 20, 2017 @10:22AM (#13687965)
Surely not if you raise a point one time to get a sense of the waters. If the management doesn't like to hear opinions from subordinates, you could pick up that vibe and stop pushing back. It might require greater social and political tact than should be necessary, but no more than needed in normal life situations.

Granted, social IQ is on a scale just like analytical analytical IQ. It would be nice for engineers if we could be blunt and to the point in our communications and let rationality win, but people aren't like that.

I'm just arguing the other end of this, because I've sometimes seen engineers be abrasive while "technically correct", and then have it cause problems for them. Being pleasant in interactions is an important skill, and I feel like sometimes it gets disregarded.

Again,sometimes even with tact and diplomacy, your bosses can still be unreasonable, and that sucks.

Re:How terrible code gets written by sane people by tluyben2 on Sunday February 19, 2017 @06:12PM (#13682760)
In some companies this is respected more than people who just obey. I would potentially promote you and I know big corp execs who would too but could be that it is more common here.